BREAKING CHANGE: remove Milvus1DocumentStore along with support for Milvus < 2.x#3552
Merged
BREAKING CHANGE: remove Milvus1DocumentStore along with support for Milvus < 2.x#3552
Conversation
agnieszka-m
approved these changes
Nov 10, 2022
Contributor
Author
|
Paging @ZanSara for reviewing the deprecation policy and @bogdankostic who did the heavy lifting. |
ZanSara
reviewed
Nov 14, 2022
ZanSara
suggested changes
Nov 14, 2022
mayankjobanputra
approved these changes
Nov 14, 2022
Contributor
mayankjobanputra
left a comment
There was a problem hiding this comment.
@masci I looked at the PR just out of curiosity... so Milvus2 doesn't require a separate docker and gets installed with the library itself?
Contributor
Author
|
@mayankjobanputra uhm are you referring to the functions in |
3c6f27b to
01e28e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Milvus2DocumentStorein favor ofMilvusDocumentStore[FIXME: link removal issue]How did you test it?
Notes for the reviewer
Checklist