ci: Speed up pylint GitHub Action#5828
Merged
masci merged 1 commit intodeepset-ai:mainfrom Sep 16, 2023
Merged
Conversation
cclauss
force-pushed
the
speed-up-pylint
branch
from
4b125eb to
5a42ab5
Compare
cclauss
added a commit
to cclauss/haystack
that referenced
this pull request
Sep 16, 2023
cclauss
added a commit
to cclauss/haystack
that referenced
this pull request
Sep 16, 2023
This reverts commit d49c86c.
cclauss
added a commit
to cclauss/haystack
that referenced
this pull request
Sep 16, 2023
masci
pushed a commit
that referenced
this pull request
Sep 18, 2023
masci
added a commit
that referenced
this pull request
Sep 20, 2023
* ci: Simplify Python code with ruff rules SIM * Revert #5828 * ruff --select=I --fix haystack/modeling/infer.py --------- Co-authored-by: Massimiliano Pippi <mpippi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
linting.ymlworkflow installing all Haystack dependencies even if not necessary #5782Proposed Changes:
As discussed at #5771 (comment) the current pylint GitHub Action builds all haystack which is not required for lining with pylint. This pull request eliminates unneeded steps so that pylint results are returned in seconds (14 sec. for 50+ Python files modified), instead of 7 to 11 minutes.
How did you test it?
Run
ruff --select=UP --fix .to modify 50+ Python files and ensure pylint runs correctly.Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.