Skip to content

Modify inference engine#1520

Merged
jeffra merged 9 commits into
deepspeedai:masterfrom
chunyang-wen:modify-inference-engine
Nov 9, 2021
Merged

Modify inference engine#1520
jeffra merged 9 commits into
deepspeedai:masterfrom
chunyang-wen:modify-inference-engine

Conversation

@chunyang-wen
Copy link
Copy Markdown
Contributor

It seems that engine module under inference package is not well developed. This PR tries to

  • Replace assert with raise and additional information. Actually assert can be turned off sometimes.
  • Remove useless import
  • Fix a bug about return_tuple
  • modify the function name of _check_quantize_setting to _init_quantization_setting

More documentation about this module is needed.

@chunyang-wen
Copy link
Copy Markdown
Contributor Author

ping @RezaYazdaniAminabadi

@RezaYazdaniAminabadi
Copy link
Copy Markdown
Contributor

Hi @chunyang-wen

Thanks for going through the inference engine-API and make these nice modifications. I will put more information on the parameters description.
Thanks,
Reza

@chunyang-wen
Copy link
Copy Markdown
Contributor Author

So should we merge this PR first and then you add further improvement or I just close it?

@RezaYazdaniAminabadi
Copy link
Copy Markdown
Contributor

So should we merge this PR first and then you add further improvement or I just close it?

No, let me please add them and we can merge it soon. Thanks

@chunyang-wen
Copy link
Copy Markdown
Contributor Author

So should we merge this PR first and then you add further improvement or I just close it?

No, let me please add them and we can merge it soon. Thanks

Sure, thanks.

@jeffra jeffra enabled auto-merge (squash) November 8, 2021 18:02
@chunyang-wen
Copy link
Copy Markdown
Contributor Author

chunyang-wen commented Nov 9, 2021

Have no idea why the check fails. From other build break logs, it seems that certain problems happen to the distributed runtime, such as port conflict or connection reset by peer.

auto-merge was automatically disabled November 9, 2021 03:01

Head branch was pushed to by a user without write access

@chunyang-wen
Copy link
Copy Markdown
Contributor Author

@jeffra please merge or open auto merge. Thanks.

@jeffra jeffra merged commit f012200 into deepspeedai:master Nov 9, 2021
@jeffra
Copy link
Copy Markdown
Collaborator

jeffra commented Nov 9, 2021

We had a CI runner failure earlier due to some new runners being misconfigured. Should be fixed now.

@chunyang-wen chunyang-wen deleted the modify-inference-engine branch November 9, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants