Generalize the model input format of the flops profiler get_model_profile() API#1768
Merged
Generalize the model input format of the flops profiler get_model_profile() API#1768
Conversation
cli99
changed the title
cli99
changed the title
cli99
changed the title
cli99
changed the title
cli99
changed the title
cli99
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
conglongli,
eltonzheng and
minjiaz
as code owners
tjruwase
approved these changes
Feb 17, 2022
B06901052
pushed a commit
to B06901052/DeepSpeed
that referenced
this pull request
Apr 14, 2022
…file() API (deepspeedai#1768) * generalize profiler model input format * fix timining of module forward Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
B06901052
pushed a commit
to B06901052/DeepSpeed
that referenced
this pull request
Apr 14, 2022
…file() API (deepspeedai#1768) * generalize profiler model input format * fix timining of module forward Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of
get_model_profileto takeargsandkwargsas model input. This is more flexible than the previous, input_shape and input_constructor implementation.For example, if a model forward is defined as
def forward(self, x, scale, intermediate_result=False, depth=1, width=0.125), the previous implementation does not work. With this PR, the user invokes the profiler byflops,macs, params = get_model_profile(model=model, args=[torch.randn(input_shape).to(device), scale], kwargs={"depth": depth, "width": width})