01 adam optimizer#1790
Merged
jeffra merged 24 commits intodeepspeedai:masterfrom Mar 11, 2022
EugeneLYC:01Adam
Merged
Conversation
EugeneLYC
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
samyam and
tjruwase
as code owners
conglongli
suggested changes
Mar 5, 2022
Contributor
conglongli
left a comment
conglongli
left a comment
There was a problem hiding this comment.
Thanks Yucheng for the great work! I left a few comments that should be easy to fix. I think this PR should be ready to merge after the fix and adding the doc/tutorial.
conglongli
suggested changes
Mar 8, 2022
Contributor
conglongli
left a comment
conglongli
left a comment
There was a problem hiding this comment.
Thanks Yucheng for applying the requested changes and adding the doc/tutorial. I reviewed and left a few minor comments.
conglongli
approved these changes
Mar 8, 2022
Contributor
conglongli
left a comment
conglongli
left a comment
There was a problem hiding this comment.
LGTM, thank you Yucheng!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maximizing Communication Efficiency for Large-scale Training via 0/1 Adam
Author: @EugeneLYC, @conglongli, @minjiaz, Christopher De Sa, Yuxiong He
Paper: https://arxiv.org/abs/2202.06009