Use parentesis around min and max to enable Windows build#449
Merged
tjruwase merged 3 commits intodeepspeedai:masterfrom Oct 1, 2020
Merged
Use parentesis around min and max to enable Windows build#449tjruwase merged 3 commits intodeepspeedai:masterfrom
tjruwase merged 3 commits intodeepspeedai:masterfrom
Conversation
bratao
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
|
|
RezaYazdaniAminabadi
approved these changes
Sep 28, 2020
Contributor
|
Thanks Bruno! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Visual C++ defines min and max as macros somewhere in windows.h, and they interfere the use of standard functions min and max.
With those changes I was able to build transformers and sparse_attention on Python 3.8 with a standard Visual Studio Build Tools 2019. I´m still working on changes to setup.py to make it work out of box, but this will be another PR.