Skip to content

[Bug fix] WarmupCosineLR issues #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 2 commits into from
Nov 16, 2023
Merged

[Bug fix] WarmupCosineLR issues #4688

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
131abb7
fix WarmupCosineLR inverse_log_warm_up math domain error
sbwww Nov 16, 2023
77dbd51
add get_last_lr to WarmupCosineLR
sbwww Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion deepspeed/runtime/lr_schedules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ def __init__(self,
self.warmup_type = warmup_type
self.warmup_min_ratio = warmup_min_ratio
self.warmup_num_steps = max(2, warmup_num_steps)
self.inverse_log_warm_up = 1.0 / math.log(warmup_num_steps)
self.inverse_log_warm_up = 1.0 / math.log(self.warmup_num_steps)

if self.total_num_steps < self.warmup_num_steps:
logger.warning('total_num_steps {} is less than warmup_num_steps {}'.format(
Expand Down Expand Up @@ -857,6 +857,12 @@ def get_lr(self):
lr_ratio = self.get_lr_ratio()
return [org_lr * lr_ratio for org_lr in self.org_lrs]

def get_last_lr(self):
""" Return last computed learning rate by current scheduler.
"""
assert getattr(self, '_last_lr', None) is not None, "need to call step() first"
return self._last_lr

def state_dict(self):
return {'last_batch_iteration': self.last_batch_iteration}

Expand Down