Skip to content

Deprecate client ability to disable gradient reduction #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 3 commits into from
Nov 24, 2020
Merged

Deprecate client ability to disable gradient reduction #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba13e98
Deprecate client ability to disable gradient reduction
tjruwase Nov 23, 2020
7d317da
Merge branch 'master' of github.com:microsoft/DeepSpeed into olruwase…
tjruwase Nov 23, 2020
5523932
Merge branch 'master' into olruwase/zero2_grad_reduce_bug
jeffra Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,11 @@ def backward(self, loss, allreduce_gradients=True, release_loss=False):
allreduce_gradients: If this is False, then gradient averaging will be skipped. Default is True.
"""

if not allreduce_gradients:
logger.warning(
f'Argument `allreduce_gradients` is deprecated, ignored, and will soon be removed'
)

# scale loss w.r.t. gradient accumulation if needed
if self.gradient_accumulation_steps() > 1:
loss = self._scale_loss(loss.float())
Expand Down Expand Up @@ -931,7 +936,7 @@ def backward(self, loss, allreduce_gradients=True, release_loss=False):
self.timers('backward_allreduce_microstep').start()
self.timers('backward_allreduce').start()

if allreduce_gradients and self.enable_backward_allreduce:
if self.enable_backward_allreduce:
self.allreduce_gradients()

if self.wall_clock_breakdown():
Expand Down
6 changes: 6 additions & 0 deletions deepspeed/runtime/zero/stage2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,12 @@ def reduce_ipg_grads(self):

with torch.cuda.stream(stream):
for _, param, param_id in self.params_in_ipg_bucket:

assert self.params_already_reduced[param_id] == False, \
f"The parameter {param_id} has already been reduced. \
Gradient computed twice for this partition. \
Multiple gradient reduction is currently not supported"

self.params_already_reduced[param_id] = True

if not self.is_param_in_current_partition[param_id]:
Expand Down