Fix Adam subgroup inconsistency#7982
Merged
delock merged 3 commits intodeepspeedai:masterfrom Apr 23, 2026
Merged
Conversation
delock
approved these changes
Apr 21, 2026
Collaborator
|
Hi @st-bang97 can you fix formatting? Thanks! |
Signed-off-by: st_bang <st.bang@dgist.ac.kr>
Contributor
Author
|
@delock maybe i fix the formatting right? if not, could you tell me which code i need to fix the format? |
Collaborator
Hi @st-bang97 you can refer to this link for the formatting error.
|
Signed-off-by: st_bang <st.bang@dgist.ac.kr>
Contributor
Author
|
@delock Thanks for your help. I edited the format of PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CPUAdam same-step subgroup drift in ZeRO-3 (#7819)
This PR ports the fix from #7820 to the latest DeepSpeed version.
It makes
Adam_Optimizer::IncrementStepidempotent for repeated calls at the same logical step and avoids unnecessary recomputation when the step has not changed.ZeRO-3/SuperOffload can invoke multiple subgroup updates within a single logical step on a shared native optimizer object. The previous logic mixed multiply and recompute paths, producing non-bit-identical bias-correction metadata across subgroup calls.
This change aligns the step-transition logic in both the CPU and XPU headers, clarifies first-step and non-sequential-step behavior, and prevents unnecessary work on repeated same-step updates.
It also adds CPUAdam regression tests covering subgroup-style repeated same-step updates through both
step_subgroup()andstep()with parameter swapping.