fix gemma4 num attention head bugs (from #7975)#7990
Conversation
Signed-off-by: Guokai Ma <guokai.ma@intel.com>
Signed-off-by: Guokai Ma <guokai.ma@intel.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb84e9c444
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # SPDX-License-Identifier: Apache-2.0 | ||
| # DeepSpeed Team | ||
|
|
||
| from transformers import Gemma4Config |
There was a problem hiding this comment.
This module-level import makes test collection fail on environments that satisfy DeepSpeed’s declared minimum (transformers>=4.51.3) but do not yet include Gemma4Config (introduced much later), because pytest errors before any skip logic can run. In those setups, unrelated unit test runs that discover tests/unit/multimodal will fail at import time instead of executing normally, so this should be wrapped in a version gate or pytest.importorskip inside the test.
Useful? React with 👍 / 👎.
Signed-off-by: Guokai Ma <guokai.ma@intel.com>
| @@ -0,0 +1,31 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
@delock please move: tests/unit/multimodal -> tests/unit/v1/multimodal
There was a problem hiding this comment.
CI only targets tests/unit/v1
Signed-off-by: Guokai Ma <guokai.ma@intel.com>
|
Hi @sfc-gh-truwase , thanks for pointing this out. The new test had been moved to v1 directory. |
2 participants
This PR is based on #7975 and fix CI errors. Thanks for @mingxiang1006 for providing the fix.