fix(fetcher): remove filter for runtime.GOOS#1319
Merged
Conversation
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
mjnagel
requested changes
Feb 12, 2026
Contributor
mjnagel
left a comment
mjnagel
left a comment
There was a problem hiding this comment.
I think there might still be an issue if a package is local. For testing I used the same bundle, but with a local pull of the init package, and hit the original issue still. I assume we may need some adjustments to the local fetcher too?
Member
Author
|
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
brandtkeller
commented
Feb 12, 2026
mjnagel
approved these changes
Feb 12, 2026
Contributor
mjnagel
left a comment
mjnagel
left a comment
There was a problem hiding this comment.
Changes make sense and work well for me locally. OK not adding a test for this in particular, we do have some existing optional component tests (although they don't seem to cover this bug since they passed).
emoskito
approved these changes
Feb 12, 2026
Contributor
|
Might just want to update the PR title to reflect removal of the GOOS filter |
brandtkeller
changed the title
slaskawi
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given my understanding of the remote fetcher - the
verifyPackageSignatureprocess should only be ran during bundle creation. Creation should not have a filter for local OS.Related Issue
Fixes #1318
Type of change
Checklist before merging