Skip to content

fix(zarf): return error from Execute#1326

Merged
emoskito merged 6 commits intomainfrom
wait-test
Feb 23, 2026
Merged

fix(zarf): return error from Execute#1326
emoskito merged 6 commits intomainfrom
wait-test

Conversation

@AustinAbro321
Copy link
Copy Markdown
Contributor

@AustinAbro321 AustinAbro321 commented Feb 20, 2026

Description

This is just to make sure the wait fix test will work with uds-cli. This includes a recent change to the zarf root command Execute() now returning an error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

AustinAbro321 and others added 2 commits February 20, 2026 15:35
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller brandtkeller changed the title test: wait fix branch from Zarf fix(zarf): return error from Execute Feb 20, 2026
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller brandtkeller marked this pull request as ready for review February 21, 2026 01:02
@brandtkeller brandtkeller requested a review from a team as a code owner February 21, 2026 01:02
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
emoskito
emoskito previously approved these changes Feb 22, 2026
@emoskito emoskito self-requested a review February 22, 2026 04:55
@emoskito emoskito dismissed their stale review February 22, 2026 04:56

Discovered output difference when zarf returns error

Copy link
Copy Markdown
Contributor

@emoskito emoskito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to display a redundant error message. For example, if I try to delete a non-existent package

Expected (v0.28.2):

$ uds version
v0.28.2
$ uds zarf p remove foo
2026-02-21 20:59:41 ERR unable to load the package: secrets "zarf-package-foo" not found

Actual:

$ ./build/uds-mac-apple zarf p remove foo
2026-02-21 21:01:48 ERR unable to load the package: secrets "zarf-package-foo" not found
     ERROR:  unable to load the package: secrets "zarf-package-foo" not found

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller
Copy link
Copy Markdown
Member

Previously zarf was executing an os.Exit(1) instead of returning an error. Updated to perform the same for parity. Open to other workflows.

@emoskito emoskito merged commit d664350 into main Feb 23, 2026
20 checks passed
@emoskito emoskito deleted the wait-test branch February 23, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants