Conversation
brandtkeller
requested changes
Apr 2, 2026
Member
brandtkeller
left a comment
brandtkeller
left a comment
There was a problem hiding this comment.
Thoughts provided for the helm ldflag.
brandtkeller
approved these changes
Apr 3, 2026
Member
brandtkeller
left a comment
brandtkeller
left a comment
There was a problem hiding this comment.
changes look correct - build flags look coordinated across task/workflow/goreleaser config. lgtm.
There was a problem hiding this comment.
Pull request overview
Migrates UDS CLI’s direct Helm dependency and related build/test wiring from Helm v3 to Helm v4, aligning version detection and ldflag injection with the newer Helm/Zarf integration described in the PR.
Changes:
- Update module/version lookups and E2E expectations from
helm.sh/helm/v3tohelm.sh/helm/v4. - Replace Helm v3 Go imports with Helm v4 equivalents (including values file parsing).
- Update build/release ldflags to remove Helm v3 k8s-version flags and inject the Helm v4 version symbol instead.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks.yaml | Uses Helm v4 for version discovery and updates build ldflags to Helm v4’s version symbol. |
| src/test/e2e/zarf_test.go | Updates tool version validation to query helm.sh/helm/v4. |
| src/pkg/bundle/overrides.go | Migrates Helm imports for values/getter to v4. |
| src/pkg/bundle/deploy_test.go | Migrates Helm values import to v4 in tests. |
| src/pkg/bundle/create.go | Switches values file parsing from Helm v3 chartutil to Helm v4 chart common reader. |
| go.mod | Removes direct Helm v3 requirement; keeps it as an indirect dependency while using Helm v4 directly. |
| .goreleaser.yaml | Updates ldflags to inject Helm v4 version symbol; removes Helm v3 k8s-version ldflags. |
| .github/workflows/release.yaml | Updates release workflow env var to pull Helm v4 module version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate direct helm imports from v3 to v4.
helm/v3remains as an indirect dependency via Zarf. Removed stale helm v3 ld flags. These changes are consistent with Zarf's recent changes in v0.74.0 release which included migration to helm v4. Thegithub.com/zarf-dev/zarf/src/cmd.helmVersionldflag had to be injected externally from uds-cli but is now baked into the module itself with v4.Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging