Split CI workflow into two stages #253
Merged
Merged
Conversation
…lding touched examples
AGulev
approved these changes
Jun 4, 2026
Contributor
AGulev
left a comment
There was a problem hiding this comment.
It looks good, but an idea for another task: use examples as test we can run nightly to make sure everething works and maybe even runs
e.g. building it for mac and then run and make screenshots on self-hosted ci-machine
Contributor
Author
Yeah, great idea, I created a separate issue for it: #254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a separate build stage for examples building touched examples.
The previous workflow combined generated-content updates, commits, Jekyll build, Pagefind indexing, and Pages deployment in one job. It also allowed multiple repository dispatch runs to update and push
masterconcurrently, which made examples updates fragile and caused repeated push failures when another generated update landed first.Now:
Update generated site: handles repository dispatch updates and pushes generated changes.Build site: builds Jekyll, runs Pagefind, uploads the Pages artifact, and deploys onmaster.Added workflow concurrency for generated updates so dispatch jobs that push generated content run serially.
Refreshed the checkout to latest
origin/masterbefore generating changesAdded deterministic examples imports using
--examples-ref.Added incremental examples imports using
--changed-examplesor--changed-examples-json.Kept full examples import as the fallback when no changed examples payload is provided.
Made update jobs lighter by removing Jekyll/Pagefind work from the update workflow and only installing Java when needed.
Examples building is very long. This should make the update path more deterministic, reduce unnecessary examples rebuild work, and separate update failures from site build failures.
This should be merged before updates in the examples: defold/examples#187