Story L: Test coverage for vBRIEF-centric document model

[MScottAdams]

Parent

Part of #309 (RFC: vBRIEF-centric document model)

Tier

Tier 4 -- CLI and tests (depends on all Tier 1-3 stories)

Scope

Comprehensive test coverage for the new vBRIEF-centric document model:

Content tests:

• Validate lifecycle folder structure in repo (proposed/, pending/, active/, completed/)
• Validate PROJECT-DEFINITION.vbrief.json schema conformance
• Verify no stale references to old file paths (SPECIFICATION.md, PROJECT.md as standalone files)
• Verify all skill directories use deft-directive-* prefix
• Verify AGENTS.md routing table matches actual skill directory names

Migration script tests:

• Test conversion of sample SPECIFICATION.md + PROJECT.md + ROADMAP.md
• Test idempotency (running twice produces same result)
• Test edge cases (missing files, empty files, malformed input)

Roadmap generation tests:

• Test deterministic output (same input -> same output)
• Test phase grouping from vBRIEF item hierarchy
• Test dependency ordering from vBRIEF edges
• Test empty pending/ produces valid ROADMAP.md
• Test GitHub issue number surfacing from references

Lifecycle validation tests:

• Test status/folder consistency checker
• Test vBRIEF filename convention validation (YYYY-MM-DD-slug.vbrief.json)
• Test origin provenance (references array) validation

Skill rename verification:

• No deft-* directories remaining under skills/ (all are deft-directive-*)
• No internal references to old skill names

Acceptance Criteria

• All test categories above have at least one test case
• task check passes with new tests included
• Coverage meets project minimum (85%)

[MScottAdams]

Closed by squash merge of PR #354 into phase2/vbrief-cutover. 28 new content/structural tests + 2 skill rename assertions added.