docs(framework): add drift/bleed rules, skills scan mandate, routing table, README fixes (#198, #200, #147, #219)#223
Conversation
Greptile SummaryThis docs-only PR adds instant-fix drift and skill-context bleed prohibitions to One gap remains: Confidence Score: 5/5Safe to merge — all findings are P2; no blocking issues remain after the vBRIEF parity fix The single remaining finding (deft-rwldl missing from README and routing table) is a bounded P2 completeness gap that is explicitly out of scope for this PR's acceptance criteria; all P0/P1 concerns from the prior review are fully resolved README.md and AGENTS.md skill routing table — both missing the deft-rwldl entry, but this is a follow-on concern rather than a merge blocker Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
U([User input / task]) --> SR{Skill Routing
keyword match?
AGENTS.md}
SR -->|yes| SK[Load matching
skills/X/SKILL.md]
SR -->|no| SC[Scan skills/ for
existing coverage
AGENTS.md ! rule]
SC -->|match found| SK
SC -->|no match| IW[Improvise
workflow]
SK --> EX[Execute skill
steps in order]
IW --> EX
EX --> EC{Skill boundary
reached?}
EC -->|yes - all steps done| STOP([Stop — return to
calling context
main.md bleed rule ⊗])
EC -->|issue discovered
mid-task| FI[File GitHub issue
do NOT fix in-place
main.md drift rule ⊗]
FI --> EX
Prompt To Fix All With AIThis is a comment left during a code review.
Path: README.md
Line: 278-282
Comment:
**`deft-rwldl` missing from skills directory tree and routing table**
`skills/deft-rwldl/` was added in commit `c674cfa` (t2.6.8, #182) and is already on disk, but it is absent from (1) this directory tree, (2) the Skills section (~line 404), and (3) `AGENTS.md`'s Skill Routing table. After this PR the README's skills list will still show 5 of 6 skills. Since t2.6.5's acceptance criteria explicitly scoped to three other skills, this is outside the current PR's mandate — but a follow-on issue to add the missing entry (routing keyword: "quality loop" / "pre-PR review" → `skills/deft-rwldl/SKILL.md`) would keep the inventory accurate.
How can I resolve this? If you propose a fix, please make it concise.Reviews (3): Last reviewed commit: "fix: address Greptile review findings (b..." | Re-trigger Greptile |
ed0d8ce to
0190dd7
Compare
…table, README fixes (#198, #200, #147, #219) - main.md: add ⊗ instant-fix drift and skill-context bleed rules (#198) - AGENTS.md: add ! skills/ scan rule before improvising workflows (#200) - AGENTS.md: add keyword->skill routing table for discoverability (#147) - README.md: add 3 missing skills, CONTRIBUTING.md, contracts/hierarchy.md (#147, #219) - meta/lessons.md: companion entries for #198, #200 - SPECIFICATION.md: add spec tasks t1.10.4, t1.10.5, t2.6.4, t2.6.5 - CHANGELOG.md: add entries under [Unreleased] Closes #198, #200, #147, #219
- vbrief/specification.vbrief.json: add 4 new spec tasks (t1.10.4, t1.10.5, t2.6.4, t2.6.5) + missing t2.6.3 to vBRIEF source - SPECIFICATION.md: mark all 4 tasks as [completed] (were [pending]) - Resolves P1: vBRIEF source sync and task status consistency
0190dd7 to
5044383
Compare
Closes #198. Closes #200. Closes #147. Closes #219.
Summary
Adds instant-fix drift and skill-context bleed prohibitions to main.md, mandatory skills/ scan rule to AGENTS.md, keyword routing table for skill discoverability, and fixes stale README content.
Changes
Checklist