Skip to content

docs(framework): add drift/bleed rules, skills scan mandate, routing table, README fixes (#198, #200, #147, #219)#223

Merged
MScottAdams merged 2 commits intomasterfrom
agent3/docs/198-200-147-219-framework-rules
Apr 7, 2026
Merged

docs(framework): add drift/bleed rules, skills scan mandate, routing table, README fixes (#198, #200, #147, #219)#223
MScottAdams merged 2 commits intomasterfrom
agent3/docs/198-200-147-219-framework-rules

Conversation

@MScottAdams
Copy link
Copy Markdown
Collaborator

Closes #198. Closes #200. Closes #147. Closes #219.

Summary

Adds instant-fix drift and skill-context bleed prohibitions to main.md, mandatory skills/ scan rule to AGENTS.md, keyword routing table for skill discoverability, and fixes stale README content.

Changes

Checklist

  • SPECIFICATION.md has task coverage (t1.10.4, t1.10.5, t2.6.4, t2.6.5)
  • CHANGELOG.md has entries under [Unreleased]
  • \ ask check\ passes (865 passed, 25 xfailed)
  • Feature branch (not direct to master)
  • /deft:change N/A (docs-only, <3 non-doc files touched)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 7, 2026

Greptile Summary

This docs-only PR adds instant-fix drift and skill-context bleed prohibitions to main.md, a mandatory skills/ scan rule and keyword routing table to AGENTS.md, and fixes stale README content. The vBRIEF source-parity concern raised in the previous review is fully resolved — all four new spec task IDs (t1.10.4, t1.10.5, t2.6.4, t2.6.5) are present in vbrief/specification.vbrief.json.

One gap remains: skills/deft-rwldl/ has been on disk since commit c674cfa but is absent from README.md's skills directory tree, the Skills section, and AGENTS.md's routing table — leaving the README still incomplete after a PR whose stated purpose is fixing stale content. This is outside the explicit acceptance criteria of t2.6.5 (which scoped to three specific skills), so it warrants a follow-on issue rather than a block.

Confidence Score: 5/5

Safe to merge — all findings are P2; no blocking issues remain after the vBRIEF parity fix

The single remaining finding (deft-rwldl missing from README and routing table) is a bounded P2 completeness gap that is explicitly out of scope for this PR's acceptance criteria; all P0/P1 concerns from the prior review are fully resolved

README.md and AGENTS.md skill routing table — both missing the deft-rwldl entry, but this is a follow-on concern rather than a merge blocker

Important Files Changed

Filename Overview
main.md Adds two ⊗ rules (instant-fix drift, skill-context bleed) and one ! exit-condition rule to Decision Making; correct and complete per t1.10.4 acceptance criteria
AGENTS.md Adds skills/ scan mandate (! + ⊗) and Skill Routing table mapping 5 trigger phrases to skill paths; deft-rwldl is on disk but absent from the routing table
README.md Adds 3 missing skills, CONTRIBUTING.md, and contracts/hierarchy.md to directory tree and relevant sections; deft-rwldl skill still absent from both skills locations
meta/lessons.md Adds two lesson entries for mid-task instant-fix drift (#198) and skills/ scan mandate (#200) with proper source attribution and issue cross-references
CHANGELOG.md Adds four [Unreleased] entries (t1.10.4, t1.10.5, t2.6.4, t2.6.5) with correct issue and task ID cross-references
vbrief/specification.vbrief.json Adds all four new task IDs resolving the prior review's vBRIEF source-parity concern; parity with SPECIFICATION.md confirmed
SPECIFICATION.md Rendered from vbrief/specification.vbrief.json with correct source parity; no direct edits without corresponding vBRIEF source

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    U([User input / task]) --> SR{Skill Routing
keyword match?
AGENTS.md}
    SR -->|yes| SK[Load matching
skills/X/SKILL.md]
    SR -->|no| SC[Scan skills/ for
existing coverage
AGENTS.md ! rule]
    SC -->|match found| SK
    SC -->|no match| IW[Improvise
workflow]
    SK --> EX[Execute skill
steps in order]
    IW --> EX
    EX --> EC{Skill boundary
reached?}
    EC -->|yes - all steps done| STOP([Stop — return to
calling context
main.md bleed rule ⊗])
    EC -->|issue discovered
mid-task| FI[File GitHub issue
do NOT fix in-place
main.md drift rule ⊗]
    FI --> EX
Loading
Prompt To Fix All With AI
This is a comment left during a code review.
Path: README.md
Line: 278-282

Comment:
**`deft-rwldl` missing from skills directory tree and routing table**

`skills/deft-rwldl/` was added in commit `c674cfa` (t2.6.8, #182) and is already on disk, but it is absent from (1) this directory tree, (2) the Skills section (~line 404), and (3) `AGENTS.md`'s Skill Routing table. After this PR the README's skills list will still show 5 of 6 skills. Since t2.6.5's acceptance criteria explicitly scoped to three other skills, this is outside the current PR's mandate — but a follow-on issue to add the missing entry (routing keyword: "quality loop" / "pre-PR review" → `skills/deft-rwldl/SKILL.md`) would keep the inventory accurate.

How can I resolve this? If you propose a fix, please make it concise.

Reviews (3): Last reviewed commit: "fix: address Greptile review findings (b..." | Re-trigger Greptile

Comment thread SPECIFICATION.md Outdated
@MScottAdams MScottAdams force-pushed the agent3/docs/198-200-147-219-framework-rules branch 2 times, most recently from ed0d8ce to 0190dd7 Compare April 7, 2026 18:51
…table, README fixes (#198, #200, #147, #219)

- main.md: add ⊗ instant-fix drift and skill-context bleed rules (#198)
- AGENTS.md: add ! skills/ scan rule before improvising workflows (#200)
- AGENTS.md: add keyword->skill routing table for discoverability (#147)
- README.md: add 3 missing skills, CONTRIBUTING.md, contracts/hierarchy.md (#147, #219)
- meta/lessons.md: companion entries for #198, #200
- SPECIFICATION.md: add spec tasks t1.10.4, t1.10.5, t2.6.4, t2.6.5
- CHANGELOG.md: add entries under [Unreleased]

Closes #198, #200, #147, #219
- vbrief/specification.vbrief.json: add 4 new spec tasks (t1.10.4, t1.10.5, t2.6.4, t2.6.5) + missing t2.6.3 to vBRIEF source
- SPECIFICATION.md: mark all 4 tasks as [completed] (were [pending])
- Resolves P1: vBRIEF source sync and task status consistency
@MScottAdams MScottAdams force-pushed the agent3/docs/198-200-147-219-framework-rules branch from 0190dd7 to 5044383 Compare April 7, 2026 18:52
@MScottAdams MScottAdams merged commit d57c90d into master Apr 7, 2026
6 checks passed
@MScottAdams MScottAdams deleted the agent3/docs/198-200-147-219-framework-rules branch April 7, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment