docs(content): deterministic principle philosophy doc and BDD strategy (#159, #81)#231
Conversation
- Create meta/philosophy.md documenting deterministic > probabilistic design principle: definition, rationale, examples (Taskfile tasks, spec_validate.py, CI workflows), scope note deferring Phase 5 work - Add meta/philosophy.md reference to contracts/hierarchy.md See also - Create strategies/bdd.md with 6-step BDD workflow: scenarios, failing tests, surface ambiguity, lock decisions, generate spec, chain into sizing gate; output artifacts, chaining gate integration, anti-patterns - Add bdd.md row to strategies/README.md as preparatory strategy - Add test_bdd_strategy_exists to tests/content/test_structure.py - Add CHANGELOG.md entries under [Unreleased] - task check passes: 875 passed, 25 xfailed
Greptile SummaryThis PR adds two documentation files as part of SPECIFICATION.md Phase 2.7: Confidence Score: 5/5Safe to merge — all findings are P2 style suggestions with no impact on correctness or runtime behavior. No P0 or P1 issues were found. Both new documentation files are internally consistent, cross-references use correct relative paths, the test passes, and CHANGELOG entries are properly formatted. The two P2 comments (missing AGENTS.md command entry, redundant explicit test) are non-blocking. No files require special attention; all changes are clean documentation additions. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A([User triggers /deft:run:bdd]) --> B[Step 1: Identify User Scenarios\nGiven/When/Then → specs/feature/acceptance-tests/]
B --> C[Step 2: Write Failing Acceptance Tests\nExecutable tests — MUST fail initially]
C --> D[Step 3: Run Tests\nSurface ambiguity & missing decisions]
D --> E[Step 4: Lock Decisions\nRecord in feature-bdd-context.md]
E --> F[Step 5: Generate Spec\nDerive SPECIFICATION.md tasks]
F --> G[Step 6: Register artifacts in vbrief/plan.vbrief.json]
G --> H{Chaining Gate}
H -->|Run more strategies| I[map / discuss / research / ...]
H -->|Proceed| J[interview.md sizing gate\nLight or Full path]
I --> H
J --> K([SPECIFICATION.md finalised])
Prompt To Fix All With AIThis is a comment left during a code review.
Path: strategies/README.md
Line: 16
Comment:
**`/deft:run:bdd` not listed in AGENTS.md Commands**
The three peer preparatory strategies `discuss`, `research`, and `map` all appear in the `AGENTS.md` Commands section (lines 64–70), making them discoverable without consulting `strategies/README.md`. The new `bdd` strategy is absent from that index. Consider adding `/deft:run:bdd <feature>` alongside the other preparatory commands so agent routing is complete.
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: tests/content/test_structure.py
Line: 172-176
Comment:
**Explicit test duplicates parametrized coverage**
`test_bdd_strategy_exists` checks for `strategies/bdd.md`, but adding `bdd.md` to `strategies/README.md` already causes the existing parametrized `test_strategy_file_exists` to cover it automatically. The dedicated function is harmless but redundant — the parametrized test will catch the same absence with a more descriptive failure message. No action required, just noting the overlap.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "docs(content): add meta/philosophy.md an..." | Re-trigger Greptile |
Summary
Two documentation tasks from SPECIFICATION.md Phase 2.7:
Task A: meta/philosophy.md (t2.7.7, #159) -- Deterministic > Probabilistic design principle
Task B: strategies/bdd.md (t2.7.8, #81) -- BDD/acceptance-test-first strategy
Validation
Files Changed
Closes #159
Closes #81