refactor(skills): rename deft-rwldl to deft-pre-pr; docs(readme): add artifact storage section (#226, #234)#262
Conversation
|
@greptileai review |
Greptile SummaryThis PR renames the Confidence Score: 5/5Safe to merge — clean rename refactor with no functional regressions and complete surface coverage. All seven required surfaces updated correctly; spec task acceptance criteria fully satisfied; tests updated and passing (946 passed per checklist); no stale live references introduced; remaining deft-rwldl mentions in ROADMAP.md are intentionally deferred historical entries per the documented release-time ROADMAP refresh process. No P0 or P1 findings. No files require special attention.
|
| Filename | Overview |
|---|---|
| skills/deft-pre-pr/SKILL.md | Renamed from deft-rwldl; frontmatter name field updated, "Formerly deft-rwldl" note added, content unchanged. |
| .agents/skills/deft-pre-pr/SKILL.md | New thin pointer replacing the removed deft-rwldl pointer; correctly references skills/deft-pre-pr/SKILL.md. |
| AGENTS.md | Adds deft-pre-pr routing entry with four trigger keywords and auto-suggestion in Development Process section; no regressions. |
| README.md | Adds deft-pre-pr to directory tree and Skills listing; adds "Your Artifacts" section; fixes stale core/project.md reference in Core Files section. |
| tests/content/test_skills.py | _PRE_PR_PATH constant updated from skills/deft-rwldl/SKILL.md to skills/deft-pre-pr/SKILL.md; all deft-pre-pr semantic-contradiction tests pass against the renamed file. |
| CHANGELOG.md | Correctly documents the rename and artifact-section addition under [Unreleased]. |
| SPECIFICATION.md | Adds t2.8.3 and t2.8.4 spec task entries; older completed entries (t2.6.8, t1.12.3) intentionally retain deft-rwldl references as historical records. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["deft-rwldl (old)"] -->|"Renamed"| B["deft-pre-pr (new)"]
subgraph surfaces ["Updated Surfaces"]
C["skills/deft-pre-pr/SKILL.md\n(frontmatter + title)"]
D[".agents/skills/deft-pre-pr/SKILL.md\n(thin pointer)"]
E["AGENTS.md\nSkill Routing + Dev Process"]
F["README.md\nDirectory tree + Skills listing"]
G["tests/content/test_skills.py\n_PRE_PR_PATH constant"]
H["CHANGELOG.md\n[Unreleased] entry"]
I["SPECIFICATION.md\nt2.8.3 task entry"]
end
B --> C
B --> D
B --> E
B --> F
B --> G
B --> H
B --> I
J["README.md"] -->|"Added"| K["Your Artifacts section\n(vbrief/, SPECIFICATION.md,\nPROJECT.md, USER.md, ./deft/)"]
style A fill:#fecaca,stroke:#ef4444,color:#000
style B fill:#86efac,stroke:#22c55e,color:#000
style K fill:#a5f3fc,stroke:#06b6d4,color:#000
Reviews (5): Last reviewed commit: "fix: add missing spec task entries t2.8...." | Re-trigger Greptile
… artifact storage section (#226, #234) - Rename skills/deft-rwldl/ directory to skills/deft-pre-pr/ for clarity (the RWLDL acronym was opaque and collided with the RWLDL tool pattern) - Update SKILL.md frontmatter name field and title heading - Create new .agents/skills/deft-pre-pr/SKILL.md thin pointer, remove old - Add deft-pre-pr to AGENTS.md Skill Routing table with trigger keywords - Add auto-suggestion to AGENTS.md Development Process section - Add deft-pre-pr to README.md directory tree and Skills listing - Update tests/content/test_skills.py to reference new skill path - Add "Your Artifacts" section to README.md documenting user-generated artifact locations (vbrief/, SPECIFICATION.md, PROJECT.md, USER.md, deft/) - Add CHANGELOG.md entries under [Unreleased]
dc1fa32 to
739feea
Compare
Summary
Two refactor/doc tasks from Phase 2:
Task A: Rename deft-rwldl to deft-pre-pr (#226, t2.8.3)
The
deft-rwldlskill name was an opaque acronym that collided with the RWLDL tool pattern. Renamed todeft-pre-prto clearly communicate the skill's purpose (iterative pre-PR quality loop).Changes:
skills/deft-rwldl/directory toskills/deft-pre-pr/namefield and title heading.agents/skills/deft-pre-pr/SKILL.mdthin pointer, removed oldtests/content/test_skills.pyto reference new skill pathTask B: README "Your Artifacts" section (#234, t2.8.4)
Added a concise bulleted list documenting where user-generated artifacts live in a consumer project:
./vbrief/,SPECIFICATION.md,PROJECT.md,USER.md,./deft/.Additional fix
core/project.mdreference in README.md Core Files section (nowPROJECT.md)Checklist
task checkpasses (946 passed, 25 xfailed)/deft:changeN/A (doc/refactor changes, no architectural impact)Closes #226, Closes #234