Skip to content

refactor(skills): rename deft-rwldl to deft-pre-pr; docs(readme): add artifact storage section (#226, #234)#262

Merged
MScottAdams merged 3 commits intomasterfrom
agent2/refactor/226-234-skill-rename-readme
Apr 9, 2026
Merged

refactor(skills): rename deft-rwldl to deft-pre-pr; docs(readme): add artifact storage section (#226, #234)#262
MScottAdams merged 3 commits intomasterfrom
agent2/refactor/226-234-skill-rename-readme

Conversation

@MScottAdams
Copy link
Copy Markdown
Collaborator

Summary

Two refactor/doc tasks from Phase 2:

Task A: Rename deft-rwldl to deft-pre-pr (#226, t2.8.3)

The deft-rwldl skill name was an opaque acronym that collided with the RWLDL tool pattern. Renamed to deft-pre-pr to clearly communicate the skill's purpose (iterative pre-PR quality loop).

Changes:

  • Renamed skills/deft-rwldl/ directory to skills/deft-pre-pr/
  • Updated SKILL.md frontmatter name field and title heading
  • Created new .agents/skills/deft-pre-pr/SKILL.md thin pointer, removed old
  • Added deft-pre-pr to AGENTS.md Skill Routing table with trigger keywords
  • Added auto-suggestion to AGENTS.md Development Process section
  • Added deft-pre-pr to README.md directory tree and Skills listing
  • Updated tests/content/test_skills.py to reference new skill path

Task B: README "Your Artifacts" section (#234, t2.8.4)

Added a concise bulleted list documenting where user-generated artifacts live in a consumer project: ./vbrief/, SPECIFICATION.md, PROJECT.md, USER.md, ./deft/.

Additional fix

  • Fixed stale core/project.md reference in README.md Core Files section (now PROJECT.md)

Checklist

  • SPECIFICATION.md has task coverage (t2.8.3, t2.8.4)
  • CHANGELOG.md entries under [Unreleased]
  • task check passes (946 passed, 25 xfailed)
  • Feature branch (not direct to master)
  • /deft:change N/A (doc/refactor changes, no architectural impact)

Closes #226, Closes #234

@MScottAdams
Copy link
Copy Markdown
Collaborator Author

@greptileai review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 9, 2026

Greptile Summary

This PR renames the deft-rwldl skill to deft-pre-pr (Task A, #226) and adds a "Your Artifacts" section to README.md (Task B, #234). The rename is applied consistently across all required surfaces: skill directory, SKILL.md frontmatter, .agents/skills/ thin pointer, AGENTS.md routing table and Development Process section, README.md directory tree and Skills listing, and tests/content/test_skills.py. All acceptance criteria in SPECIFICATION.md t2.8.3 and t2.8.4 are satisfied. Remaining deft-rwldl references in ROADMAP.md phase bodies and the Open Issues Index are intentionally deferred to the next release-time ROADMAP refresh, per the AGENTS.md development process.

Confidence Score: 5/5

Safe to merge — clean rename refactor with no functional regressions and complete surface coverage.

All seven required surfaces updated correctly; spec task acceptance criteria fully satisfied; tests updated and passing (946 passed per checklist); no stale live references introduced; remaining deft-rwldl mentions in ROADMAP.md are intentionally deferred historical entries per the documented release-time ROADMAP refresh process. No P0 or P1 findings.

No files require special attention.

Vulnerabilities

No security concerns identified. All changes are documentation and skill-file renaming with no code execution paths.

Important Files Changed

Filename Overview
skills/deft-pre-pr/SKILL.md Renamed from deft-rwldl; frontmatter name field updated, "Formerly deft-rwldl" note added, content unchanged.
.agents/skills/deft-pre-pr/SKILL.md New thin pointer replacing the removed deft-rwldl pointer; correctly references skills/deft-pre-pr/SKILL.md.
AGENTS.md Adds deft-pre-pr routing entry with four trigger keywords and auto-suggestion in Development Process section; no regressions.
README.md Adds deft-pre-pr to directory tree and Skills listing; adds "Your Artifacts" section; fixes stale core/project.md reference in Core Files section.
tests/content/test_skills.py _PRE_PR_PATH constant updated from skills/deft-rwldl/SKILL.md to skills/deft-pre-pr/SKILL.md; all deft-pre-pr semantic-contradiction tests pass against the renamed file.
CHANGELOG.md Correctly documents the rename and artifact-section addition under [Unreleased].
SPECIFICATION.md Adds t2.8.3 and t2.8.4 spec task entries; older completed entries (t2.6.8, t1.12.3) intentionally retain deft-rwldl references as historical records.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["deft-rwldl (old)"] -->|"Renamed"| B["deft-pre-pr (new)"]

    subgraph surfaces ["Updated Surfaces"]
        C["skills/deft-pre-pr/SKILL.md\n(frontmatter + title)"]
        D[".agents/skills/deft-pre-pr/SKILL.md\n(thin pointer)"]
        E["AGENTS.md\nSkill Routing + Dev Process"]
        F["README.md\nDirectory tree + Skills listing"]
        G["tests/content/test_skills.py\n_PRE_PR_PATH constant"]
        H["CHANGELOG.md\n[Unreleased] entry"]
        I["SPECIFICATION.md\nt2.8.3 task entry"]
    end

    B --> C
    B --> D
    B --> E
    B --> F
    B --> G
    B --> H
    B --> I

    J["README.md"] -->|"Added"| K["Your Artifacts section\n(vbrief/, SPECIFICATION.md,\nPROJECT.md, USER.md, ./deft/)"]

    style A fill:#fecaca,stroke:#ef4444,color:#000
    style B fill:#86efac,stroke:#22c55e,color:#000
    style K fill:#a5f3fc,stroke:#06b6d4,color:#000
Loading

Reviews (5): Last reviewed commit: "fix: add missing spec task entries t2.8...." | Re-trigger Greptile

… artifact storage section (#226, #234)

- Rename skills/deft-rwldl/ directory to skills/deft-pre-pr/ for clarity
  (the RWLDL acronym was opaque and collided with the RWLDL tool pattern)
- Update SKILL.md frontmatter name field and title heading
- Create new .agents/skills/deft-pre-pr/SKILL.md thin pointer, remove old
- Add deft-pre-pr to AGENTS.md Skill Routing table with trigger keywords
- Add auto-suggestion to AGENTS.md Development Process section
- Add deft-pre-pr to README.md directory tree and Skills listing
- Update tests/content/test_skills.py to reference new skill path
- Add "Your Artifacts" section to README.md documenting user-generated
  artifact locations (vbrief/, SPECIFICATION.md, PROJECT.md, USER.md, deft/)
- Add CHANGELOG.md entries under [Unreleased]
- Update stale deft-rwldl path in CHANGELOG.md [0.14.2] entry to
  deft-pre-pr with parenthetical noting the rename
- Remove duplicate section-header comment in test_skills.py (lines
  789-793 had both #27 and #26 for the same block)
@MScottAdams MScottAdams force-pushed the agent2/refactor/226-234-skill-rename-readme branch from dc1fa32 to 739feea Compare April 9, 2026 18:28
- Add t2.8.3: rename deft-rwldl to deft-pre-pr (#226) with acceptance criteria
- Add t2.8.4: README Your Artifacts section (#234) with acceptance criteria
- Addresses Greptile P1 finding on PR #262
@MScottAdams MScottAdams merged commit 7ab7ed6 into master Apr 9, 2026
9 checks passed
@MScottAdams MScottAdams deleted the agent2/refactor/226-234-skill-rename-readme branch April 9, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant