Skip to content

docs(roadmap): refresh -- add #279, #272, #269 to Phase 1, #274 to Phase 1 Cleanup#280

Merged
MScottAdams merged 5 commits intomasterfrom
roadmap-refresh
Apr 10, 2026
Merged

docs(roadmap): refresh -- add #279, #272, #269 to Phase 1, #274 to Phase 1 Cleanup#280
MScottAdams merged 5 commits intomasterfrom
roadmap-refresh

Conversation

@MScottAdams
Copy link
Copy Markdown
Collaborator

Summary

Roadmap refresh triaging 4 new issues into the phased roadmap, with spec task skeletons for each.

Related Issues

N/A -- triage PR, no issues closed by this PR directly.

Checklist

  • /deft:change -- N/A (documentation-only, <3 logical changes, non-architectural)
  • CHANGELOG.md -- added Roadmap Refresh (2026-04-10) entry under [Unreleased]
  • ROADMAP.md -- updated with 4 new issues in phase bodies, Open Issues Index, and update history
  • Tests pass locally -- 881 content tests pass; WinError 448 in test_atomic_write_creates_file is a pre-existing Windows temp path issue unrelated to these changes

Post-Merge

  • Verify issue auto-close: N/A -- no closing keywords in this PR

…hase 1 Cleanup

- #279 (Phase 1 Adoption Blocker, t1.14.1): deft-review-cycle Approach 2 idle stoppage -- yield ends turn in Warp execution model, breaking swarm polling loop; add warning, ! rule preferring Approach 1 for swarm agents, anti-pattern
- #272 (Phase 1 Adoption Blocker, t1.16.1): deft-setup agent conflates framework directory with project root during bootstrap -- reads ./PROJECT.md relative to framework clone instead of pwd, silently skips setup; add ! rule anchoring paths to pwd at skill entry
- #269 (Phase 1 Adoption Blocker, t1.17.1): Warp auto-approve silently self-answers deft-setup interview, producing garbage USER.md/PROJECT.md; add post-interview confirmation gate + document Always Ask Warp setting; absorbs #271
- #274 (Phase 1 Cleanup, t1.15.1): extend mandatory pre-commit file review with semantic accuracy check for counts/claims in CHANGELOG entries and ROADMAP changelog lines
- Analysis comments posted on all 4 issues; no stale entries
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 10, 2026

Greptile Summary

This documentation-only PR triages four issues (#279, #272, #269, #274) into Phase 1, files three additional issues (#281, #282, #283), and adds spec-task skeletons for all seven in SPECIFICATION.md. The previously reported t2.8.1 heading truncation has been resolved — the [completed] marker and issue reference are restored correctly.

Confidence Score: 5/5

Safe to merge — documentation-only changes with one minor semantic wording inconsistency.

All changed content is documentation. The only finding is P2: ROADMAP.md describes the current deft-roadmap-refresh review as "4-check" when it currently has 3 checks. The SPECIFICATION.md correctly says "fourth check category." The t2.8.1 regression flagged in the prior review is now fixed. No code paths, schemas, or tests are affected.

ROADMAP.md line 20 — the #274 entry wording.

Important Files Changed

Filename Overview
CHANGELOG.md Adds a single "Roadmap Refresh (2026-04-10)" entry accurately distinguishing 4 triaged issues from 3 newly-filed issues; counts and spec-task IDs match ROADMAP and SPECIFICATION.
ROADMAP.md Phase body, Open Issues Index, and update history all updated for 7 issues; minor semantic inaccuracy in the #274 entry ("4-check pre-commit review") — the current deft-roadmap-refresh review has 3 checks, making 4 the future state after #274 ships.
SPECIFICATION.md Seven spec-task skeletons added (t1.14.1–t1.20.1) with correct [pending] status; t2.8.1 [completed] marker and issue reference restored after prior truncation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[4 Incoming Issues<br/>#279 #272 #269 #274] --> B{Triage}
    B --> C[Phase 1 Adoption Blockers<br/>#279 t1.14.1<br/>#272 t1.16.1<br/>#269 t1.17.1]
    B --> D[Phase 1 Cleanup<br/>#274 t1.15.1]
    C --> E[Spec task skeletons<br/>added to SPECIFICATION.md]
    D --> E
    E --> F[3 New Issues Filed<br/>#281 t1.18.1<br/>#282 t1.19.1<br/>#283 t1.20.1]
    F --> G[Phase 1 Cleanup<br/>+ Spec skeletons]
    G --> H[ROADMAP.md<br/>phase bodies + index + history]
    E --> H
    H --> I[CHANGELOG.md<br/>Roadmap Refresh 2026-04-10]
Loading
Prompt To Fix All With AI
This is a comment left during a code review.
Path: ROADMAP.md
Line: 20

Comment:
**"4-check" count doesn't match the current review state**

`deft-roadmap-refresh/SKILL.md` Phase 4 currently lists three mandatory file-review checks (encoding, duplication, structural). `SPECIFICATION.md` t1.15.1 correctly describes the fix as adding a "fourth check category." The ROADMAP description "extend the **4-check** pre-commit review" implies the review already has four checks, which contradicts both the current skill file and the spec task — and is exactly the class of semantic inaccuracy #274 is designed to prevent.

```suggestion
- **#274** -- Add semantic accuracy check to mandatory pre-commit file review: extend the 3-check pre-commit review in deft-roadmap-refresh (and add a 5th check in deft-build, which gained a semantic-contradiction check via #251) to verify counts and claims in CHANGELOG entries and ROADMAP changelog lines match actual data (t1.15.1)
```

How can I resolve this? If you propose a fix, please make it concise.

Reviews (5): Last reviewed commit: "fix: restore # Changelog H1 heading stri..." | Re-trigger Greptile

Comment thread SPECIFICATION.md Outdated
- SPECIFICATION.md t2.8.1: restore [completed] status and full title suffix stripped during new spec task insertion
- ROADMAP.md + SPECIFICATION.md: add #281 (Phase 1 Cleanup, t1.18.1) -- WinError 448 pytest-current symlink cleanup fails on Windows 11 24H2+
- CHANGELOG.md: update 2026-04-10 Roadmap Refresh entry to include #281
- SPECIFICATION.md t2.7.8: restore Traces #81 (was corrupted to #281 by PS regex replace)
- SPECIFICATION.md: remove ghost empty ## t2.8.1: heading inserted by PS regex replace
- ROADMAP.md + SPECIFICATION.md + CHANGELOG.md: add #282 (Phase 1 Cleanup, t1.19.1) -- deft-review-cycle MCP capability detection + task check pre-existing failure carve-out
- CHANGELOG.md: strip UTF-8 BOM introduced by [System.Text.Encoding]::UTF8 shorthand
- ROADMAP.md: add #283 (Phase 1 Cleanup, t1.20.1) -- AGENTS.md ! rule for BOM-safe PS file writes
- SPECIFICATION.md: add t1.20.1 skeleton for #283
- CHANGELOG.md: update 2026-04-10 Roadmap Refresh entry to include #283
@MScottAdams MScottAdams merged commit b2cd125 into master Apr 10, 2026
9 checks passed
@MScottAdams MScottAdams deleted the roadmap-refresh branch April 10, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant