fix(review-cycle): optimize Greptile review cycle + add Approach 3 fallback + interview routing fix#330
Conversation
Greptile SummaryThis PR addresses four independent issues in one bundle: (1) mandating Confidence Score: 5/5Safe to merge — all spec criteria are satisfied, the previous Approach 2 timing concern is resolved, and only two minor documentation gaps remain (P2). All four spec tasks (t1.30.1, t1.31.1, t1.32.1, t1.26.1) fully satisfy their acceptance criteria. The only findings are a CHANGELOG entry that omits the Unix fallback and a matching gap in the t1.32.1 spec criterion — both P2 documentation issues that don't affect runtime behaviour. CHANGELOG.md and SPECIFICATION.md (t1.32.1 criterion) — minor documentation gaps around the Unix/macOS grep fallback; no functional files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Review Monitoring triggered] --> B{start_agent available?}
B -- Yes --> C[Tier 1: Approach 1\nSpawn sub-agent monitor\n20-30s / 60s / 90s cadence]
B -- No --> D{scheduler / timer /\nauto-reinvocation available?}
D -- Yes --> E[Tier 2: Approach 2\nYield-between-polls\nRuntime-controlled ~60s interval]
D -- No --> F{Interactive session?}
F -- Yes --> G[Tier 3: Approach 3\nWarn user → get confirmation\nBlocking sleep loop\n25s / 60s / 90s cadence]
F -- No --> H[No monitoring path available\nDocument and escalate]
C --> I{Exit condition met?\nconfidence > 3, no P0/P1}
E --> I
G --> I
I -- No --> J[Wait and re-poll]
J --> I
I -- Yes --> K[Proceed to Step 5]
Prompt To Fix All With AIThis is a comment left during a code review.
Path: CHANGELOG.md
Line: 13
Comment:
**CHANGELOG entry understates Task C scope**
The entry says "(Windows/PowerShell context)" but `SKILL.md` also ships a Unix/macOS `grep` fallback alongside the `Select-String` one. A reader scanning the CHANGELOG for the Unix fallback won't find a reference to it.
```suggestion
- **Select-String fallback for oversized gh pr view output** (#328, t1.32.1): Added ~ fallback commands to deft-review-cycle Phase 2 Step 1 for when do_not_summarize_output produces output too large to process — PowerShell (`Select-String "Outside Diff" -Context 50`) and Unix/macOS (`grep -A 50 "Outside Diff"`)
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: SPECIFICATION.md
Line: 1257-1259
Comment:
**t1.32.1 acceptance criteria only verify the PowerShell fallback**
The implementation added both a PowerShell (`Select-String`) and a Unix/macOS (`grep -A 50`) fallback, but the spec only verifies the PowerShell command and notes "Windows/PowerShell context". The Unix fallback is real behaviour with no spec coverage.
```suggestion
- skills/deft-review-cycle/SKILL.md Phase 2 Step 1 contains ~ fallback guidance for oversized output with two platform variants: PowerShell: `gh pr view <number> --comments | Select-String "Outside Diff" -Context 50`; Unix/macOS: `gh pr view <number> --comments | grep -A 50 "Outside Diff"`
- Fallback is positioned after the `do_not_summarize_output: true` rule
- Guidance labels each variant by platform (PowerShell/Windows vs Unix/macOS)
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (3): Last reviewed commit: "fix: address Greptile review findings (b..." | Re-trigger Greptile |
…llback + interview routing fix Closes #305, #307, #328, #301 - Mandate deft-pre-pr before PR creation (AGENTS.md ! rule + Phase 1 gate) - Add PR scope gate warning for 3+ unrelated surfaces - Adaptive poll cadence (20-30s/60s/90s replacing fixed 60s) - Parallel rebase + review monitoring guidance in deft-swarm Phase 6 - .greptile/rules.md starter template elevated to SHOULD - Approach 3 interactive blocking fallback with user warning gate - Select-String fallback for oversized gh pr view output - Tighten deft-interview routing keyword (interview loop / q&a loop)
- Scope Approach 2 adaptive cadence note to clarify yield-mode limitation - Add Unix/macOS grep equivalent for Select-String fallback - Update stale ~60s cadence reference in deft-swarm to adaptive cadence
c18a7f0 to
d762df3
Compare
|
Rebase-only force-push onto updated master (after PR #329 merge). Only CHANGELOG.md conflict resolved -- merged both PRs' [Unreleased] entries. No logic changes. |
Summary
Optimize Greptile review cycle and fix 3 related issues in one PR.
Closes #305, #307, #328, #301
Changes
Task A: Greptile review cycle optimization (#305, t1.30.1) -- 5 changes
Task B: Approach 3 interactive blocking fallback (#307, t1.31.1)
Task C: Select-String fallback for oversized output (#328, t1.32.1)
gh pr view <number> --comments | Select-String "Outside Diff" -Context 50Task D: Tighten deft-interview routing keyword (#301, t1.26.1)
interviewin AGENTS.md Skill Routing withinterview loop/q&a loop/run interview loopChecklist
/deft:change <name>-- N/A (bundled swarm task, all changes trace to spec tasks)CHANGELOG.md-- added entries under [Unreleased]ROADMAP.md-- N/A (updated at release time)Post-Merge
masterrequiring CI status check