docs(vbrief): rename deft-setup+interview to deft-directive-* and rewrite for vBRIEF model

[MScottAdams]

Summary

Rename skills/deft-setup/ to skills/deft-directive-setup/ and skills/deft-interview/ to skills/deft-directive-interview/, rewriting both for the vBRIEF-centric document model (Phase 2 vBRIEF Architecture Cutover).

Key changes:

• deft-directive-setup: Phase 2 outputs PROJECT-DEFINITION.vbrief.json (not PROJECT.md); Phase 3 adds onboarding question (adding scope vs starting new) with repo-state-aware default; Full path writes rich narratives (ProblemStatement, Goals, UserStories, Requirements, SuccessMetrics, Architecture, Overview) to specification.vbrief.json; Light path creates scope vBRIEFs in vbrief/proposed/; approval gate reviews vBRIEF narratives (not PRD.md); handoff updated to deft-directive-build
• deft-directive-interview: Adds Output Targets section documenting Full path (7 rich narrative keys) and Light path (Overview + Architecture) vBRIEF output; PRD.md no longer generated on either path; task prd:render added for optional stakeholder export
• Updated .agents/skills/ thin pointers, all cross-skill references, 21 existing tests, and added 13 new vBRIEF-model assertions
• Created tasks/prd.yml with task prd:render wired into Taskfile.yml

Related Issues

Closes #314
Closes #319

Part of #309 (RFC: vBRIEF-centric document model)

Checklist

• /deft:change <name> -- N/A (doc/skill rewrite per RFC RFC: vBRIEF-centric document model for Deft Directive #309 stories, <3 source files changed)
• CHANGELOG.md -- added entry under [Unreleased]
• ROADMAP.md -- N/A (ROADMAP updates happen at release time)
• Tests pass locally (task check -- 1253 passed, 0 failed)

Post-Merge

• Verify issue auto-close: After squash merge, confirm Story E: deft-directive-setup (rename + rewrite for vBRIEF model) #314 and Story J: deft-directive-interview (namespace rename) #319 actually closed
• Enable branch protection on master requiring CI status check (one-time setup, see Add GitHub Actions CI workflow for linting and tests on PRs and pushes #57)

[greptile-apps]

Greptile Summary

This PR renames skills/deft-setup/ → skills/deft-directive-setup/ and skills/deft-interview/ → skills/deft-directive-interview/, rewrites both for the vBRIEF-centric document model (Phase 2 cutover), and introduces task prd:render (tasks/prd.yml + scripts/prd_render.py) for optional stakeholder PRD export. All previously flagged P0/P1 findings — missing prd_render.py, dangling deft-directive-build reference, SyntaxError injections in test_skills.py, and the stale deft-setup path in SKILL_PATHS — have been resolved in the follow-up fix commits bundled into this branch.

Confidence Score: 5/5

Safe to merge — all previously flagged P0/P1 issues are resolved and only minor P2 style findings remain.

The three original blocking issues (missing prd_render.py, dangling deft-directive-build reference, SyntaxError injections in test_skills.py) were all resolved in follow-up fix commits. The remaining findings are a duplicate CHANGELOG line, a hardcoded banner path in prd_render.py, and a weak footer test — none affect runtime behaviour or test correctness.

CHANGELOG.md (duplicate entry on line 15); scripts/prd_render.py (hardcoded BANNER path)

Important Files Changed

Filename	Overview
CHANGELOG.md	Has a duplicate entry for the #314/#319 change: the corrupt line (with commit-message garbage appended) was not deleted when the clean replacement line was added by the injection-fix commit.
scripts/prd_render.py	New script for PRD export; logic is correct but BANNER hardcodes the default spec path regardless of --spec argument, producing a misleading source-of-truth comment when a custom path is passed.
tests/cli/test_prd_render.py	7 tests cover happy paths, ordering, error handling, and empty narratives; test_prd_render_footer only checks that banner strings exist in content rather than verifying footer placement at document end.
tasks/prd.yml	Correctly wires task prd:render to prd_render.py with CLI_ARGS passthrough; sources/generates entries match default spec and output paths.
tests/content/test_skills.py	SyntaxError injections resolved; SKILL_PATHS updated to deft-directive-* names; 13 new vBRIEF-model assertions added for sections 34-35; no remaining stale paths.
skills/deft-directive-setup/SKILL.md	Complete rewrite for vBRIEF model; handoff references deft-directive-build (skill exists); Phase 3 onboarding question, rich narrative keys, light/full paths, and anti-patterns all correctly documented.
skills/deft-directive-interview/SKILL.md	Output Targets section added with Full/Light path narrative keys; PRD.md correctly marked as optional export only; invocation contract (embedded vs delegation modes) present.
Taskfile.yml	prd namespace correctly included as optional; no issues.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[deft-directive-setup Phase 3] -->|Full path| B[Interview via deft-directive-interview]
    A -->|Light path| C[slim narratives: Overview + Architecture]
    B --> D[Write specification.vbrief.json\nplan.narratives with 7 rich keys]
    C --> E[Create scope vBRIEFs\nin vbrief/proposed/]
    D --> F[User reviews vBRIEF narratives\napproval gate]
    F -->|Approved| G[Handoff to deft-directive-build]
    F -->|Optional export| H[task prd:render\nscripts/prd_render.py]
    H --> I[PRD.md\nread-only export artifact]
    E --> G

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: CHANGELOG.md
Line: 15

Comment:
**Duplicate CHANGELOG entry with residual commit-message garbage**

The injection-fix commit (`f12603c`) added a clean replacement entry for the #314/#319 change (line 16) but did not remove the original corrupt line. Line 15 ends with the same commit subject appended twice: `...added 13 new vBRIEF-model assertions: rename deft-setup+interview to deft-directive-* and rewrite for vBRIEF model (#314, #319)): rename deft-setup+interview...`. The clean line 16 is the correct entry; line 15 should be deleted.

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: scripts/prd_render.py
Line: 33-36

Comment:
**BANNER hardcodes default spec path regardless of `--spec` argument**

The `BANNER` constant always embeds `vbrief/specification.vbrief.json` as the declared source of truth. When a caller passes `--spec some/other/path.json` (e.g. in tests or multi-project setups), the generated PRD's banner will still claim `vbrief/specification.vbrief.json`, which is factually incorrect. Consider computing the banner inside `render_prd` using the actual `spec_path` argument:

```python
def render_prd(spec_path: Path, output_path: Path) -> None:
    banner = (
        "<!-- AUTO-GENERATED by task prd:render -- DO NOT EDIT -->\n"
        f"<!-- Source of truth: {spec_path} -->\n"
    )
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: tests/cli/test_prd_render.py
Line: 187-195

Comment:
**`test_prd_render_footer` only verifies banner strings, not footer placement**

Both `"AUTO-GENERATED"` and `"task prd:render"` appear in the `BANNER` at the top of every generated file, so this test would pass even if the footer block were removed entirely. To actually verify a footer exists, check the tail of the document:

```python
assert content.rstrip().endswith("Do not edit directly.*")
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (6): Last reviewed commit: "fix: add missing closing paren in test_d..." | Re-trigger Greptile}

[MScottAdams]

@greptileai review

[MScottAdams]

Review cycle complete (2 passes).

Round 1 findings (resolved in batch commit):

• P1: Created scripts/prd_render.py + tests/cli/test_prd_render.py (7 tests)
• P2: Updated deft_version from 0.15.0 to 0.19.0 (4 occurrences)

Round 2 findings (out of scope):

• P2: skills/deft-build/SKILL.md still references deft-setup -- this file is explicitly in the do-not-touch list for this PR. The rename is tracked in Story F (Story F: deft-directive-build, review-cycle, pre-pr (rename + update) #315).
• P2: test_deft_build_user_md_gate_redirects_to_deft_setup -- this is a deft-build test, not a setup/interview test per PR constraints. Will be updated in Story F.
• P2: Handoff references deft-directive-build which doesn't exist yet -- consistent with AGENTS.md (already merged in Story D: Core doc updates (main.md, AGENTS.md) for vBRIEF-centric model #313), will resolve when Story F renames deft-build.

Confidence: 4/5. All P0/P1 in-scope issues resolved. Not merging per instructions.