docs(vbrief): rename deft-swarm to deft-directive-swarm with flexible vBRIEF allocation

[MScottAdams]

Summary

Closes #317

Rename skills/deft-swarm/ to skills/deft-directive-swarm/ and update for flexible vBRIEF allocation as part of the Phase 2 vBRIEF Architecture Cutover (RFC #309, Story H).

Key Changes

Skill Rename:

• Renamed skills/deft-swarm/ directory to skills/deft-directive-swarm/
• Updated .agents/skills/ thin pointer (deft-swarm -> deft-directive-swarm)
• Updated SKILL.md frontmatter name to deft-directive-swarm

Phase 0 -- vBRIEF-centric Allocation (replaces ROADMAP.md/SPECIFICATION.md analysis):

• Monitor scans vbrief/active/ for story-level vBRIEFs instead of reading ROADMAP.md/SPECIFICATION.md
• Flexible multi-vBRIEF allocation per agent: small/independent stories can be batched, large/complex stories get dedicated agents
• Monitor decides allocation dynamically based on scope, complexity, and dependencies -- no hardcoded 1:1 rule (RFC D9)

Phase 5 -- Complete vBRIEFs (new subsection):

• On story completion, move vBRIEF from active/ to completed/ via task scope:complete
• Update vBRIEF plan.status field to completed
• Read references and update origins (close GitHub issues with comment referencing merged PR) (RFC D11)

Cross-skill References:

• Updated all internal references from deft-* to deft-directive-* (review-cycle, refinement)
• Removed all references to ROADMAP.md and SPECIFICATION.md as source-of-truth documents
• Updated prompt template to reference vbrief/active/ for task discovery

Tests:

• Updated 41 test functions in tests/content/test_skills.py for new path
• Added 7 new tests: flexible allocation, vBRIEF completion lifecycle, origin updates, frontmatter name, no old name references, no hardcoded allocation anti-pattern

Checklist

• AGENTS.md read
• task check passes (1248 passed, 2 xfailed)
• CHANGELOG.md entry added under [Unreleased]
• Conventional commit message format
• Feature branch (not master)
• No files outside scope touched

[greptile-apps]

Greptile Summary

This PR renames skills/deft-swarm/ to skills/deft-directive-swarm/, updates the .agents/ thin pointer, rewrites Phase 0 to scan vbrief/active/ for flexible multi-vBRIEF allocation (replacing the hardcoded ROADMAP.md/SPECIFICATION.md analysis), and adds a Phase 5 "Complete vBRIEFs" subsection that correctly defers origin/issue closure to Phase 6 post-merge. Cross-skill references in deft-review-cycle and scm/github.md are updated to the new name, and 48 test functions are updated (41 path updates + 7 new acceptance-criteria tests).

The previously flagged issue (premature issue closure in Phase 5) is fully resolved — the ⚠️ callout at line 252 explicitly guards against it and the action is deferred to Phase 6 Step 2.

Confidence Score: 5/5

Safe to merge — all changes are documentation and test updates with no logic code; the single P2 finding is a trivial import-placement style issue.

All findings are P2 or lower. The blocking concern from the previous review round (premature issue closure) has been addressed with an explicit ⚠️ guard and the closure action moved to Phase 6. The rename is internally consistent across all changed files and tests pass (1248 passed per checklist).

tests/content/test_skills.py — minor import placement style issue (import re inside function body at line 1188).

Important Files Changed

Filename	Overview
skills/deft-directive-swarm/SKILL.md	Core skill rename + Phase 0 vBRIEF allocation rewrite; Phase 5 correctly defers origin/issue closure to Phase 6 with an explicit ⚠️ callout.
.agents/skills/deft-directive-swarm/SKILL.md	New thin-pointer created; old deft-swarm thin pointer deleted. Pointer body and frontmatter name are correct.
skills/deft-review-cycle/SKILL.md	Updated cross-skill reference from deft-swarm to deft-directive-swarm in Post-Merge Verification; no other functional changes.
scm/github.md	Updated 'See also' reference from skills/deft-swarm to skills/deft-directive-swarm in Post-Merge Issue Verification section.
CHANGELOG.md	Correct [Unreleased] entry added under Changed; historical entries retain old deft-swarm name as appropriate context.
tests/content/test_skills.py	_SWARM_PATH constant updated to new path; 7 new tests added for #317 acceptance criteria; minor P2: import re placed inside test function body instead of at module level.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    P0[Phase 0 -- Allocate
Scan vbrief/active/ for story vBRIEFs
Flexible allocation: batch small, dedicate for large] --> P1[Phase 1 -- Select
File-overlap audit]
    P1 --> P2[Phase 2 -- Setup
Create worktrees + prompt files]
    P2 --> P3[Phase 3 -- Launch
Detect start_agent / Warp / manual]
    P3 --> P4[Phase 4 -- Monitor
Track agent checkpoints]
    P4 --> P5[Phase 5 -- Review & Complete
Verify Greptile confidence > 3
Move vBRIEFs: active to completed
NO issue closure here]
    P5 -->|Phase 5-6 Gate
User approval required| P6[Phase 6 -- Close
Merge cascade
Close origin issues post-merge
Update vBRIEF references
Slack announcement]

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: tests/content/test_skills.py
Line: 1188-1189

Comment:
**`import re` should be at module level**

`import re` is placed inside the test function body. While Python caches imports after the first call so there's no runtime penalty, PEP 8 requires all imports at the top of the file. Moving it to the module-level import block keeps the convention consistent with the rest of the file.

Place `import re` at the top of `test_skills.py` alongside the other imports, and remove this inline import.

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (7): Last reviewed commit: "fix: update deft-swarm prose refs in def..." | Re-trigger Greptile}