Skip to content

feat(strategies): convert research, map to vBRIEF-centric outputs; redirect roadmap to refinement (#367, #368, #369)#378

Merged
MScottAdams merged 1 commit intophase2/vbrief-cutoverfrom
agent3/feat/367-368-369-research-map-roadmap
Apr 14, 2026
Merged

feat(strategies): convert research, map to vBRIEF-centric outputs; redirect roadmap to refinement (#367, #368, #369)#378
MScottAdams merged 1 commit intophase2/vbrief-cutoverfrom
agent3/feat/367-368-369-research-map-roadmap

Conversation

@MScottAdams
Copy link
Copy Markdown
Collaborator

Summary

Convert research and map strategies to vBRIEF-centric outputs; redirect roadmap strategy to refinement skill.

Changes

research.md (#367)

  • Output changed from {feature}-research.md to vbrief/proposed/{feature}-research.vbrief.json
  • Two narratives: DontHandRoll and CommonPitfalls
  • Chaining gate artifact registration updated

map.md (#368)

  • Output changed from .planning/codebase/ (4 separate .md files) to single vbrief/proposed/{project}-codebase-map.vbrief.json
  • Four narratives: Stack, Architecture, Conventions, Concerns
  • Chaining gate artifact registration updated

roadmap.md (#369)

  • Replaced with superseded redirect to deft-directive-refinement skill and task roadmap:render
  • Follows same pattern as brownfield.md redirect

Tests

  • 16 tests in tests/content/test_strategy_conversions.py
  • Added exempt entries for roadmap.md shape and RFC2119 tests in known_failures.json

Checklist

  • CHANGELOG.md updated
  • task check passes (1428 tests, 0 failures)
  • Conventional commit message
  • New test file for new code

Closes #367
Closes #368
Closes #369
Parent: #338

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 14, 2026

Greptile Summary

Converts research.md and map.md outputs to vBRIEF JSON artifacts in vbrief/proposed/ and replaces roadmap.md with a superseded-redirect stub, completing the vBRIEF-centric strategy migration series. All three changes follow patterns already established by prior PRs (brownfield.md redirect, bdd/discuss/rapid conversions), the 16 new tests match the PR description's count, and the two new known_failures.json exempt entries mirror the brownfield precedent exactly.

Confidence Score: 5/5

Safe to merge — all changes follow established patterns, tests are correct, and no P0/P1 issues were found.

All findings are P2 or lower. The three strategy conversions are consistent with the migration series already merged on this branch. The 16 tests correctly verify the new output paths and narrative names. The known_failures.json additions exactly mirror the brownfield.md precedent. The only outstanding concern (CHANGELOG conflict marker) was already flagged in a prior review thread and is not re-raised here.

No files require special attention.

Important Files Changed

Filename Overview
strategies/research.md Output path migrated from {feature}-research.md to vbrief/proposed/{feature}-research.vbrief.json with DontHandRoll/CommonPitfalls narratives; chaining gate updated correctly.
strategies/map.md Output consolidated from 4 .planning/codebase/*.md files to a single vbrief/proposed/{project}-codebase-map.vbrief.json with Stack/Architecture/Conventions/Concerns narratives; chaining gate updated correctly.
strategies/roadmap.md Replaced with minimal superseded-redirect stub pointing to skills/deft-directive-refinement/SKILL.md and task roadmap:render, mirroring the brownfield.md pattern.
tests/content/test_strategy_conversions.py 16 tests across 3 classes verify vBRIEF output paths, narrative names, absence of legacy paths, and chaining gate artifact registration; count matches PR description.
tests/content/snapshots/known_failures.json Added two exempt entries for roadmap.md (shape and RFC2119 tests), following the identical pattern used for brownfield.md.
CHANGELOG.md New entry accurately describes all three strategy conversions; pre-existing conflict marker at line 12 was flagged in a prior review thread.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Agent invokes strategy] --> B{Which strategy?}

    B --> C[research.md]
    B --> D[map.md]
    B --> E[roadmap.md]

    C --> C1["Produce vbrief/proposed/\n{feature}-research.vbrief.json\n(DontHandRoll + CommonPitfalls)"]
    D --> D1["Produce vbrief/proposed/\n{project}-codebase-map.vbrief.json\n(Stack + Architecture + Conventions + Concerns)"]
    E --> E1["⚠️ Superseded Redirect\n→ skills/deft-directive-refinement/SKILL.md\n→ task roadmap:render"]

    C1 --> F["Register in vbrief/plan.vbrief.json\n(completedStrategies + artifacts)"]
    D1 --> F

    F --> G["Return to interview.md\nChaining Gate"]
    E1 --> H["User redirected to\ndeft-directive-refinement skill"]
Loading

Reviews (4): Last reviewed commit: "feat(strategies): convert research, map ..." | Re-trigger Greptile

@MScottAdams MScottAdams force-pushed the agent3/feat/367-368-369-research-map-roadmap branch from 6696f18 to 40e5987 Compare April 14, 2026 22:35
@MScottAdams
Copy link
Copy Markdown
Collaborator Author

Rebase-only force-push — no logic changes, rebased onto updated phase2/vbrief-cutover after PR #376 merge.

@MScottAdams MScottAdams force-pushed the agent3/feat/367-368-369-research-map-roadmap branch from 40e5987 to 0e6e6b5 Compare April 14, 2026 22:44
Comment thread CHANGELOG.md Outdated
…direct roadmap to refinement (#367, #368, #369)

- research.md: output changed from {feature}-research.md to vbrief/proposed/{feature}-research.vbrief.json with DontHandRoll and CommonPitfalls narratives

- map.md: output changed from .planning/codebase/ (STACK.md, ARCHITECTURE.md, CONVENTIONS.md, CONCERNS.md) to single vbrief/proposed/{project}-codebase-map.vbrief.json with Stack, Architecture, Conventions, Concerns narratives

- roadmap.md: replaced with superseded redirect to deft-directive-refinement skill and task roadmap:render (brownfield.md pattern)

- Updated chaining gate artifact registrations for research and map strategies

- Added roadmap.md exempt entries for shape and RFC2119 tests in known_failures.json

- 16 tests in tests/content/test_strategy_conversions.py covering all acceptance criteria
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant