Change over from collection models to use of array schema #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathob
force-pushed
the
array-schema
branch
3 times, most recently
from
ce3a439 to
0a481f3
Compare
This BREAKING change removes the wrapping of collections into a
collection model class.
Until today, a collection in JSON would always look like this:
```json
{
"entities": [
{ "key": "value" }
]
}
```
This was caused by model classes in the following style:
```java
@XmlRootElement(name = BootstrAPI.ENTITIES)
public class EntitiesBean {
@xmlelement
private Collection<EntityBean> entities;
}
```
These classes now have fully been removed, and `List<EntityBean>` is
directly returned by all resources, so that the JSON for collections now
always looks like this:
```json
[
{ "key": "value" }
]
```
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This BREAKING change removes the wrapping of collections into a collection model class.
Until today, a collection in JSON would always look like this:
{ "entities": [ { "key": "value" } ] }This was caused by model classes in the following style:
These classes now have fully been removed, and
List<EntityBean>isdirectly returned by all resources, so that the JSON for collections now
always looks like this:
[ { "key": "value" } ]