Add DELETE for the default SMTP and POP mail servers#478
Merged
Conversation
Allows removing the default mail server configuration through the API; the operation is idempotent and returns 204 whether or not a server was configured. Crowd does not support removing its mail configuration and throws UnsupportedOperationException, consistent with its POP operations. This also makes the mail server functional tests deterministic and duplication-free: the "not configured" precondition tests now delete any existing configuration first instead of relying on a pristine instance, so they no longer depend on test class execution order or on a freshly extracted product home. The EXAMPLE_2 mail server models are redefined to be greenmail-compatible (see ci.yaml), letting the Confluence and Jira functional tests use the shared defaults instead of per-product overrides.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows removing the default mail server configuration through the API; the operation is idempotent and returns 204 whether or not a server was configured. Crowd does not support removing its mail configuration and throws UnsupportedOperationException, consistent with its POP operations.
This also makes the mail server functional tests deterministic and duplication-free: the "not configured" precondition tests now delete any existing configuration first instead of relying on a pristine instance, so they no longer depend on test class execution order or on a freshly extracted product home. The EXAMPLE_2 mail server models are redefined to be greenmail-compatible (see ci.yaml), letting the Confluence and Jira functional tests use the shared defaults instead of per-product overrides.