Prevent partial reads/writes

[paragonie-scott]

Reference: #125

[paragonie-scott]

Issues that should be fixed now:

• In File, length of returned values are not checked. #114
• File still uses old string keys, not Key objects. #132
• Testing of File is insufficient. #133
• Possibly Use only pure streaming operations, except for one rewind. #134 (thought we might want to keep that open until audited)

[defuse]

Fuck, I want to reply to one of @paragonie-scott's comments, but I can't remember which commit it's in, and GitHub doesn't give me the link.

No, it doesn't return false. You threw a return; in encryptFile() and the unit tests didn't catch it.

So I accidentally added a return statement somewhere in the function, and that broke it, without breaking the unit tests, and returning true ensures that they'll catch it in the future? Could you document that (or just point me to a commit), I'd like to improve the unit tests so that they'll catch it.

[defuse]

@paragonie-scott: I think you addressed all my comments, is this ready to merge?

[paragonie-scott]

I believe it's ready.
On Dec 11, 2015 2:03 AM, "Taylor Hornby" notifications@github.com wrote:

@paragonie-scott https://github.com/paragonie-scott: I think you
addressed all my comments, is this ready to merge?

—
Reply to this email directly or view it on GitHub
#129 (comment)
.