Skip to content

Conversation

@twistor
Copy link
Contributor

@twistor twistor commented Dec 15, 2015

No description provided.

@paragonie-scott
Copy link
Collaborator

  1. Defuse\Crypto\FileTest::testFileCreateRandomKey

Failed asserting that Binary String: 0xec5a666a1d861...c6fcc64 is an instance of class "\Defuse\Crypto\Key".

I'm not sure where this change-set caused the reported failure (was it at the same time as another change?). This is a good idea, however.

@twistor
Copy link
Contributor Author

twistor commented Dec 15, 2015

That's not from this patch.

I get the same failure running v2.0 locally.

@paragonie-scott
Copy link
Collaborator

Okay, well this looks great to me. 👍

@defuse
Copy link
Owner

defuse commented Dec 22, 2015

@paragonie-scott Yeah, that was a bug. I think it's fixed in the v2.0 branch now.

defuse added a commit that referenced this pull request Dec 22, 2015
Add helper method for openssl_cipher_iv_length().
@defuse defuse merged commit a32bc7f into defuse:v2.0 Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants