Skip to content

Conversation

@defuse
Copy link
Owner

@defuse defuse commented Apr 10, 2016

No description provided.

@defuse
Copy link
Owner Author

defuse commented Apr 10, 2016

(The tests are failing because pgp.mit.edu is being retarded.)

@larowlan
Copy link
Contributor

Should/could we add a section on upgrading from 1.2?
If 2.0 is the LTS version then getting people off the earlier version will lead to lower support overhead

@defuse
Copy link
Owner Author

defuse commented Apr 10, 2016

@larowlan Absolutely yes! Good call.

@defuse
Copy link
Owner Author

defuse commented Apr 24, 2016

Finally done and ready for review. 99% chance I made a copy/paste error somewhere. The stuff in docs/classes is like 80% copy-pasting the same paragraph over and over so it's likely I made mistakes there.

@defuse defuse changed the title Version 2.0.0 Documentation Version 2.0.0 Documentation (and other things) Apr 24, 2016
@defuse
Copy link
Owner Author

defuse commented Apr 24, 2016

Note that this PR contains security-related changes, e.g. adding poor-man's domain separation for #240

docs/Tutorial.md Outdated

Let's say Alice and Dave trust each other, and Alice is going to host Dave's
application on her server. But both Alice and Dave don't trust Eve. They know
Eve is a good database administrator, but he might have incentive to steal the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eve is a guy?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! (I originally had "Mallory" and did a string replacement for "Eve").

@larowlan larowlan mentioned this pull request Apr 25, 2016
@glensc
Copy link
Contributor

glensc commented Apr 30, 2016

you say:

This library requres no special dependencies except for a version of PHP 5.4 or newer with the OpenSSL extensions enabled (the default). It comes bundled with random_compat so that your users will not need to follow any special installation steps.

why it's necessary to bundle copy for third-party library in this repo, why not keep repo for source code only. i.e use composer dependency and for .phar files use github release page to upload the phar. repo history is already 15MiB for a library that is 56KiB size!

bundling copy of some library is directly against having secure system. if it was not bundled, i could update the library separately. now i install this library and don't even know maybe it has old version of third party library.

besides the solutions how not to bundle already exists, which i mentioned (composer, release uploads)

@defuse defuse merged commit 04eac8e into v2.0 May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants