WIP: create .phar using existing tools (composer, box.phar) #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| curl -LSs https://box-project.github.io/box2/installer.php | php | ||
|
|
||
| composer.phar: | ||
| curl -sS https://getcomposer.org/installer | php |
Owner
There was a problem hiding this comment.
NACK on the above two curl commands. Let's instead document that developers need to install box.phar and composer in docs/InternalDeveloperDocs, and let them decide how securely they want to acquire them.
Contributor
Author
There was a problem hiding this comment.
➔ PATH=/usr/bin make
Makefile:7: *** Required tool `box' not installed, see docs/InstallingAndVerifying.md. Stop.
make condition was always evaluated true
Contributor
Author
|
moved the dist making scripts to dist/ subdir, also dropped automatic download and point use to documentation if tool can not be found from local system. also to ensure dirty changes don't get into tarball, i export git tree to get clean view of committed changes. this means unwanted and not verified changes don't have chance to slip into the .phar accidentally. |
This was referenced May 15, 2016
Owner
|
I incorporated this into #264, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#257
WIP: basic concept, when accepted needs cleanups (dropping library copies and unused scripts)
box.pharINSTRUCTIONS:
commands must be run in
dist/subdir, git tree must be clean (uncommitted changes will not be "seen")makemake cleanbuild system will attempt to find tools from `$PATH` fallbacking to current dir, if these are missing they can be downloaded with: - `make composer.phar` - `make box.phar`