Add type safety analysis to Travis CI #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defuse
approved these changes
Apr 26, 2017
Owner
defuse
left a comment
defuse
left a comment
There was a problem hiding this comment.
This is a neat improvement. All of the changes LGTM. How do I run it manually? Maybe add it to the list of development dependencies in https://github.com/defuse/php-encryption/blob/master/docs/InternalDeveloperDocs.md and add it to the release build instructions?
Collaborator
Author
|
Oh, that's very easy.
I'll update the documentation. |
Collaborator
Author
|
I added the instructions to the documentation. I'm going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request uses psalm to perform static analysis on every pull request and commit to master (as part of our Travis CI suite).
It also contains some idiomatic changes (e.g.
$var === false->!\is_string($var)).