Skip to content

Conversation

@defuse
Copy link
Owner

@defuse defuse commented Apr 23, 2018

No description provided.

@defuse defuse self-assigned this Apr 23, 2018
@defuse
Copy link
Owner Author

defuse commented Apr 23, 2018

I need to carefully review this when I'm not sleep deprived.

@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #398 into master will increase coverage by 8.89%.
The diff coverage is 98.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   82.56%   91.45%   +8.89%     
==========================================
  Files           9        9              
  Lines         958      925      -33     
==========================================
+ Hits          791      846      +55     
+ Misses        167       79      -88
Impacted Files Coverage Δ
src/File.php 84.79% <100%> (+3.95%) ⬆️
src/Core.php 90.2% <100%> (+11.4%) ⬆️
src/RuntimeTests.php 87.36% <100%> (+9.79%) ⬆️
src/Key.php 100% <100%> (+11.11%) ⬆️
src/Crypto.php 98.85% <100%> (+19.85%) ⬆️
src/Encoding.php 98% <100%> (+4%) ⬆️
src/KeyOrPassword.php 96.42% <90.9%> (+4.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fba0c...d2b04d2. Read the comment docs.

@defuse defuse changed the title Eliminate a lot of "impossible-to-cover" lines by changing the if (unlikely) throw EnvironmentIsBroken pattern into an assertion function call Improve Test Coverage Apr 23, 2018
@defuse defuse merged commit 0d4d27c into master Apr 23, 2018
@paragonie-scott paragonie-scott deleted the make-throw-ifs-an-assert branch March 15, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants