Skip to content

Conversation

@gohjohn
Copy link

@gohjohn gohjohn commented Sep 6, 2018

This feature should be a solution to issue #34

Use setOriginalImage to set an image that will be placed under all strokes.

The image will persist undos and clears and redraws.

To remove the image, call setOriginalImage with a nil param

@dehli
Copy link
Owner

dehli commented Sep 6, 2018

Thanks for the PR @gohjohn! Since TouchDrawView inherits from UIImageView, it already has an image property. I think we can probably solve this only using that instead of introducing another image variable. I'll mess around with getting it working (and if it's not possible I will merge this PR). Cheers! 👍

@gohjohn
Copy link
Author

gohjohn commented Sep 7, 2018

Cheers! 👍

@dehli
Copy link
Owner

dehli commented Sep 28, 2018

Hey @gohjohn, sorry it took so long for me to get to this! I submitted another PR (#38) where I solved the problem a little differently. If you get a chance to look through it/test it out, let me know your thoughts!

@dehli
Copy link
Owner

dehli commented Oct 3, 2018

Closing this PR as it's been implemented slightly differently with becd1dc. Let me know if there's any issues with it!

@dehli dehli closed this Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants