Skip to content

chore(cargo-mono): add typia publish tag target#341

Merged
kdy1 merged 1 commit intomainfrom
kdy1/add-typia-publish-tag
Mar 28, 2026
Merged

chore(cargo-mono): add typia publish tag target#341
kdy1 merged 1 commit intomainfrom
kdy1/add-typia-publish-tag

Conversation

@kdy1
Copy link
Copy Markdown
Contributor

@kdy1 kdy1 commented Mar 28, 2026

Summary

  • add typia to [workspace.metadata.cargo-mono.publish.tag].packages in root Cargo.toml
  • allow cargo-mono publish to create release tags for typia

Testing

  • not run (configuration-only change)

@kdy1 kdy1 enabled auto-merge (squash) March 28, 2026 02:03
@kdy1 kdy1 merged commit 412af9c into main Mar 28, 2026
16 checks passed
@kdy1 kdy1 deleted the kdy1/add-typia-publish-tag branch March 28, 2026 02:03
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e0e3f6948

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml

[workspace.metadata.cargo-mono.publish.tag]
packages = ["nodeup", "cargo-mono"]
packages = ["nodeup", "cargo-mono", "typia"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid allowlisting typia until it is publishable

Adding typia to the publish-tag allowlist does not enable tag creation right now because crates/typia/Cargo.toml still has publish = false, and cargo-mono publish filters non-publishable packages before it ever calls tag creation (execute in crates/cargo-mono/src/commands/publish.rs). That means this new entry is currently unreachable and the intended release-tag behavior for typia will not occur until publishability is changed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant