Fixed DeleteVolume with remaining host access#320
Merged
Conversation
…PublishVolumeRequest.
… FailedPrecondition according to the CSI spec.
Contributor
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
ChristianAtDell
approved these changes
Jun 25, 2025
JacobGros
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a race condition in the CSI driver's DeleteVolume handler caused by delayed host access updates in the Unity array.
When ControllerPublishVolume sends a host access request to the array, the Unity API may respond slowly. If Kubernetes times out and cancels the request before the array completes the operation, the array may still proceed to add host access in the background.
Subsequently, ControllerUnpublishVolume may run and succeed because the host access hasn't appeared yet. However, by the time DeleteVolume is called, the host access might have been added, causing the array to reject the volume deletion. Kubernetes, unaware of this intermediate state, retries the deletion repeatedly with the same failure.
To resolve this, the DeleteVolume handler now checks for and removes any existing host access before attempting to delete the volume.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?