Rename package to fix golangci-lint check error#324
Conversation
lukeatdell
left a comment
There was a problem hiding this comment.
Renaming utils to serviceutils doesn't truly resolve the issues outlined by the revive error message: avoid meaningless package names.
serviceutils is just as meaningless as utils, and tells us nothing about what kind of functions we can expect to find in the package, and only serves as a workaround to the revive check.
Instead, I suggest identifying functions from utils that have a similar purpose or operate on similar data/structs and moving those to an aptly named package.
I have updated code now. I have divided |
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Requested change by Luke is added. Received sufficient approvals. As Luke is on leave, so dismissing the review to proceed with merging.
Description
Rename package to fix golangci-lint check error
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration