Skip to content

Fix for invalid topology labels due to delays in initiators login state report#341

Merged
alexemc merged 11 commits into
mainfrom
usr/babija/iscsi-init-fix
Sep 2, 2025
Merged

Fix for invalid topology labels due to delays in initiators login state report#341
alexemc merged 11 commits into
mainfrom
usr/babija/iscsi-init-fix

Conversation

@alexemc
Copy link
Copy Markdown
Contributor

@alexemc alexemc commented Aug 28, 2025

Description

To provide the supported topology to NodeGetInfo, the driver fetches the initiator from the array right after the local initiator login. In some environments, it takes some time for the array to start reporting this initiator as connected. The driver just skips the initiator if it's reported as disconnected, so the node does not get the iscsi label, so no iscsi volumes are created on this node by CO.
The fix makes the driver aware of this condition and retry querying the array for up to 5 minutes.
Since the same API is used for both FC and iSCSI, the change protect both protocols from this condition.
Logging and error handling was significantly improved as well.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/2003

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • unit-tests
  • OCP E2E tests

JacobGros
JacobGros previously approved these changes Aug 29, 2025
Comment thread service/node.go Outdated
Comment thread service/node.go
Comment thread service/node.go Outdated
anathoodell
anathoodell previously approved these changes Sep 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2025

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-unity/service 86.41% (+0.12%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-unity/service/node.go 80.39% (+0.51%) 979 (+15) 787 (+17) 192 (-2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-unity/service/node_test.go

@alexemc alexemc merged commit 99a1d38 into main Sep 2, 2025
6 checks passed
@alexemc alexemc deleted the usr/babija/iscsi-init-fix branch September 2, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants