Fix for invalid topology labels due to delays in initiators login state report#341
Merged
Conversation
…ies when there are multiple initiators per array.
JacobGros
previously approved these changes
Aug 29, 2025
anathoodell
reviewed
Aug 29, 2025
anathoodell
reviewed
Aug 29, 2025
anathoodell
previously approved these changes
Sep 2, 2025
anathoodell
approved these changes
Sep 2, 2025
Contributor
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
shaynafinocchiaro
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To provide the supported topology to NodeGetInfo, the driver fetches the initiator from the array right after the local initiator login. In some environments, it takes some time for the array to start reporting this initiator as connected. The driver just skips the initiator if it's reported as disconnected, so the node does not get the iscsi label, so no iscsi volumes are created on this node by CO.
The fix makes the driver aware of this condition and retry querying the array for up to 5 minutes.
Since the same API is used for both FC and iSCSI, the change protect both protocols from this condition.
Logging and error handling was significantly improved as well.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration