Skip to content

Removed karavi namespace dependency from csm-operator for observability#1027

Merged
niranjan-n1 merged 12 commits intomainfrom
usr/niranjan/remove_karavi_ns_dependency
Jul 7, 2025
Merged

Removed karavi namespace dependency from csm-operator for observability#1027
niranjan-n1 merged 12 commits intomainfrom
usr/niranjan/remove_karavi_ns_dependency

Conversation

@niranjan-n1
Copy link
Copy Markdown
Contributor

@niranjan-n1 niranjan-n1 commented Jul 1, 2025 •
edited
Loading

Description

PR to remove karavi namespace dependency. All the observability pods will be deployed in the csm cr namespace

Doc PR: dell/csm-docs#1580

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran operator e2e with --obs tag
  • Ran observability e2e with powerscale driver

obs-e2e-op.txt

Metrics and topology test :
Powerscale:
topology.txt
metrics.txt
Powerflex:
topology-pflex.txt
metrics-pflex.txt

isilon vxflexos

@niranjan-n1 niranjan-n1 marked this pull request as draft July 1, 2025 11:07
@niranjan-n1 niranjan-n1 mentioned this pull request Jul 3, 2025
Merged
5 tasks
@niranjan-n1 niranjan-n1 changed the title removed karavi ns dependency Removed karavi namespace dependency from csm-operator for observability Jul 3, 2025
@niranjan-n1 niranjan-n1 marked this pull request as ready for review July 3, 2025 07:25
HarishH-DELL
HarishH-DELL reviewed Jul 4, 2025
View reviewed changes
HarishH-DELL
HarishH-DELL reviewed Jul 4, 2025
View reviewed changes
HarishH-DELL
HarishH-DELL reviewed Jul 4, 2025
View reviewed changes
@niranjan-n1 niranjan-n1 requested a review from HarishH-DELL July 4, 2025 09:07
HarishH-DELL
HarishH-DELL previously approved these changes Jul 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chimanjain
chimanjain previously approved these changes Jul 4, 2025
View reviewed changes
rajendraindukuri
rajendraindukuri reviewed Jul 4, 2025
View reviewed changes
@niranjan-n1 niranjan-n1 dismissed stale reviews from chimanjain and HarishH-DELL via 63f6412 July 7, 2025 05:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 7, 2025

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csm-operator/pkg/modules 90.22% (-0.15%) 👎
github.com/dell/csm-operator/pkg/operatorutils 94.54% (ø)
github.com/dell/csm-operator/tests/e2e/steps 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csm-operator/pkg/modules/observability.go 91.67% (-0.56%) 456 (-46) 418 (-45) 38 (-1) 👎
github.com/dell/csm-operator/pkg/operatorutils/status.go 94.15% (ø) 410 386 24
github.com/dell/csm-operator/pkg/operatorutils/utils.go 95.37% (ø) 562 536 26
github.com/dell/csm-operator/tests/e2e/steps/steps_def.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csm-operator/pkg/modules/observability_test.go
  • github.com/dell/csm-operator/pkg/operatorutils/status_test.go

@niranjan-n1 niranjan-n1 merged commit 2a6c293 into main Jul 7, 2025
6 checks passed
@niranjan-n1 niranjan-n1 deleted the usr/niranjan/remove_karavi_ns_dependency branch July 7, 2025 09:50
santhoshatdell pushed a commit that referenced this pull request Jul 10, 2025
@niranjan-n1 @santhoshatdell
Removed karavi namespace dependency from csm-operator for observabili…
a905f08 
…ty (#1027)

Signed-off-by: santhoshatdell <Santhosh.Lakshmanan@dell.com>
santhoshatdell added a commit that referenced this pull request Jul 10, 2025
@santhoshatdell
Initial changes to support CSi secret store provider
cd702c5 
Auth v2 - Add support for SecretProviderClass

Updates to CRD and map usage in sample

convert map to list for SecretProviderClasses

Bump sigs.k8s.io/yaml from 1.4.0 to 1.5.0 in the golang group (#1024)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Rename package to fix golangci-lint check error (#1031)

Co-authored-by: JacobGros <jacobgrosner4@gmail.com>
Co-authored-by: Gosa <kumar_karthik.gosa@dell.com>

skipCertificateValidation Support in PowerStore CSI Driver (#1010)

Co-authored-by: karthikk92 <92289639+karthikk92@users.noreply.github.com>

SDC v4.5.4 SHA id updated for PowerFlex v2.14.0 sample (#1030)

Added unit tests

Updated the SFTP secrets to .crt files in e2e (#1025)

Removed karavi namespace dependency from csm-operator for observability (#1027)

Update go version to 1.24 (#1028)

Co-authored-by: csm-release[bot] <183133423+csm-release[bot]@users.noreply.github.com>
Co-authored-by: alexemc <32580729+alexemc@users.noreply.github.com>

Replication support for Powerstore (#1026)

Fixed lint error

Initial Operator e2e changes

Create secretproviderclass, and set namespace label for OCP

Updating vault script with latest changes

Addressed review comments
santhoshatdell pushed a commit that referenced this pull request Jul 10, 2025
@niranjan-n1 @santhoshatdell
Removed karavi namespace dependency from csm-operator for observabili…
dcb8281 
…ty (#1027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov

@falfaroc falfaroc Awaiting requested review from falfaroc

@coulof coulof Awaiting requested review from coulof

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@JacobGros JacobGros Awaiting requested review from JacobGros

@karthikk92 karthikk92 Awaiting requested review from karthikk92

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa

@meggm meggm Awaiting requested review from meggm

@mgandharva mgandharva Awaiting requested review from mgandharva

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

2 more reviewers

@chimanjain chimanjain chimanjain approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@niranjan-n1 @chimanjain @rajendraindukuri @HarishH-DELL