Skip to content

updated powermax sample file and test files#776

Merged
harishp8889 merged 10 commits intomainfrom
bugfix/samples-update
Nov 21, 2024
Merged

updated powermax sample file and test files#776
harishp8889 merged 10 commits intomainfrom
bugfix/samples-update

Conversation

@harishp8889
Copy link
Copy Markdown
Contributor

@harishp8889 harishp8889 commented Nov 13, 2024

Description

  1. Updated e2e files by removing unused envs.
  2. Updated CSM-Powermax sample files

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1566

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran e2e and attached the screens
image image image image image

Copy link
Copy Markdown
Contributor

@nitesh3108 nitesh3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove X_CSI_POWERMAX_ENDPOINT from operatorconfig as well

@harishp8889
Copy link
Copy Markdown
Contributor Author

harishp8889 commented Nov 19, 2024

remove X_CSI_POWERMAX_ENDPOINT from operatorconfig as well

Removed

@ChristianAtDell
Copy link
Copy Markdown
Contributor

Merged main into this branch and addressed merge conflict, which should bring UT coverage up unless code was added and not tested in this branch.

@harishp8889 harishp8889 merged commit bc9613e into main Nov 21, 2024
@harishp8889 harishp8889 deleted the bugfix/samples-update branch November 21, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants