Skip to content

Fix powerscale e2e alt ocp#790

Merged
gilltaran merged 6 commits intomainfrom
fix-powerscale-e2e-alt-ocp
Nov 20, 2024
Merged

Fix powerscale e2e alt ocp#790
gilltaran merged 6 commits intomainfrom
fix-powerscale-e2e-alt-ocp

Conversation

@gilltaran
Copy link
Copy Markdown
Collaborator

Description

In OCP clusters, the master nodes have the taint - key: "node-role.kubernetes.io/master" and not - key: "node-role.kubernetes.io/control-plane" so the controller pods are looking for a taint that doesn't exist in the E2E test scenarios that uses existing alternate values file. The toleration - key: "node-role.kubernetes.io/master" should be added. More details in the ticket

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1600

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

report-test-run-bfdfd42b.txt

Copy link
Copy Markdown
Contributor

@mgandharva mgandharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gilltaran gilltaran merged commit 611a5a2 into main Nov 20, 2024
@gilltaran gilltaran deleted the fix-powerscale-e2e-alt-ocp branch November 20, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants