Skip to content

[BUG]: Remove entries in CSI PowerMax Samples of CSM operator#795

Merged
riya-kaushal7997 merged 1 commit intomainfrom
bugfix/remove-stale-entries-powermax-reverseproxy
Nov 26, 2024
Merged

[BUG]: Remove entries in CSI PowerMax Samples of CSM operator#795
riya-kaushal7997 merged 1 commit intomainfrom
bugfix/remove-stale-entries-powermax-reverseproxy

Conversation

@riya-kaushal7997
Copy link
Copy Markdown
Contributor

@riya-kaushal7997 riya-kaushal7997 commented Nov 22, 2024

Description

Remove stale entries from CSI Powermax Reverseproxy CR

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1585

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

The operator e2e tests were executed successfully. Full log attached in Jira ticket.

  • Install PowerMax Driver(Standalone)
  • Install PowerMax Driver(Sidecar)

@riya-kaushal7997 riya-kaushal7997 marked this pull request as draft November 22, 2024 12:43
@mgandharva mgandharva marked this pull request as ready for review November 25, 2024 10:37
Copy link
Copy Markdown
Contributor

@mgandharva mgandharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@harishp8889 harishp8889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please sign the commits to merge

@harishp8889 harishp8889 self-requested a review November 26, 2024 10:35
Copy link
Copy Markdown
Contributor

@harishp8889 harishp8889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsigned commits to be fixed

remove stale entries for pmax reverseproxy

Updated PR checklist
@riya-kaushal7997 riya-kaushal7997 force-pushed the bugfix/remove-stale-entries-powermax-reverseproxy branch from 8048edc to 159b743 Compare November 26, 2024 11:44
@riya-kaushal7997
Copy link
Copy Markdown
Contributor Author

fixed the unsigned commits.

Copy link
Copy Markdown
Contributor

@mgandharva mgandharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@riya-kaushal7997 riya-kaushal7997 merged commit 9859820 into main Nov 26, 2024
@riya-kaushal7997 riya-kaushal7997 deleted the bugfix/remove-stale-entries-powermax-reverseproxy branch November 26, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants