Remove Extra Fields From Minimal CR#800
Merged
AkshaySainiDell merged 50 commits intomainfrom Dec 20, 2024
Merged
Conversation
Contributor
|
When installing powermax using minimal sample, we are adding the reverseproxy module to the CR: csm-operator/pkg/drivers/powermax.go Line 98 in d7827cb |
rajendraindukuri
previously approved these changes
Dec 4, 2024
kumarp20
previously approved these changes
Dec 16, 2024
suryagupta4
approved these changes
Dec 20, 2024
rajendraindukuri
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the extra fields from the CSM CR when deploying using a minimal sample. ensuring it is cleaner, more efficient, and thoroughly validated. Below is a summary of the changes:
Key Changes
Replica Count Fix
Removal of Empty Fields
csiDriver,Node, andControllerfrom the CR.Environment Variable Cleanup
KUBELET_CONFIG_DIRfield from the CR.PowerFlex-Specific Changes
initContainerandsdc-monitorfields for PowerFlex in the minimal configuration.PowerMax-Specific Changes
reverseproxyenv variable fields for PowerMax in the minimal configuration.Improved Unit Test Coverage
Fix Operator Crashing
E2E Test Enhancements
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration