Skip to content

Modifiable values consistent across drivers#830

Merged
rishabhatdell merged 4 commits intomainfrom
consistency_all_driver
Dec 23, 2024
Merged

Modifiable values consistent across drivers#830
rishabhatdell merged 4 commits intomainfrom
consistency_all_driver

Conversation

@rishabhatdell
Copy link
Copy Markdown
Contributor

@rishabhatdell rishabhatdell commented Dec 18, 2024 •
edited
Loading

Description

  • This PR made modifiable values in values.yaml consistent across drivers
  • Fixed CVE-2024-45338

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1647

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed Powerflex driver with new yaml
  • Built Image
  • Ran e2e for a driver
    image

@rishabhatdell rishabhatdell changed the title made values.yaml consistent across drivers Modifiable values consistent across drivers Dec 18, 2024
@rishabhatdell rishabhatdell marked this pull request as ready for review December 18, 2024 11:37
shanmydell
shanmydell previously approved these changes Dec 18, 2024
View reviewed changes
mgandharva
mgandharva reviewed Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mgandharva mgandharva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabhatdell, Don't changes in E2E sample files be required?

suryagupta4
suryagupta4 previously approved these changes Dec 18, 2024
View reviewed changes
adarsh-dell
adarsh-dell reviewed Dec 18, 2024
View reviewed changes
adarsh-dell
adarsh-dell reviewed Dec 18, 2024
View reviewed changes
@rishabhatdell rishabhatdell dismissed stale reviews from suryagupta4 and shanmydell via 0ce34ae December 19, 2024 08:33
gilltaran
gilltaran approved these changes Dec 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gilltaran gilltaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabhatdell rishabhatdell merged commit d825739 into main Dec 23, 2024
@rishabhatdell rishabhatdell deleted the consistency_all_driver branch December 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gilltaran gilltaran gilltaran approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell

@alikdell alikdell Awaiting requested review from alikdell

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@chimanjain chimanjain Awaiting requested review from chimanjain

@coulof coulof Awaiting requested review from coulof

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@gallacher gallacher Awaiting requested review from gallacher

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@JacobGros JacobGros Awaiting requested review from JacobGros

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

@karthikk92 karthikk92 Awaiting requested review from karthikk92

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa

@bandak2 bandak2 Awaiting requested review from bandak2

@meggm meggm Awaiting requested review from meggm

@mjsdell mjsdell Awaiting requested review from mjsdell

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

@panigs7 panigs7 Awaiting requested review from panigs7

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@atye atye Awaiting requested review from atye

@sharmilarama sharmilarama Awaiting requested review from sharmilarama

+6 more reviewers

@donatwork donatwork donatwork left review comments

@adarsh-dell adarsh-dell adarsh-dell left review comments

@mgandharva mgandharva mgandharva left review comments

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@shanmydell shanmydell shanmydell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@rishabhatdell @donatwork @shanmydell @gilltaran @AkshaySainiDell @suryagupta4 @adarsh-dell @mgandharva