[bug-1737]: Check if CSM is Authorization Proxy Server by checking module name

[atye]

Description

When calculating state, the CSM name is checked to determine if the CSM is the Authorization Proxy Server or not. If the CSM name is not the default name, authorization, reconciling fails. Determining if the CSM is the Authorization Proxy Server or not should be be hardened by checking if a module name in the spec is authorization-proxy-server.

Changes:

• Check if the CSM is the Authorization Proxy Server by checking the module name in the spec
• Add missing deployment check for authorization-controller when checking Authorization status
• go mod tidy in tests/e2e to make build pass in image scan action

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1737

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility
• I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Updated and new unit tests. Installed Authorization using default and non-default names.

# kubectl -n csm-authorization get csm
NAME                CREATIONTIME   CSIDRIVERTYPE   CONFIGVERSION   STATE
csm-authorization   56s                                            Succeeded


# kubectl -n csm-authorization get csm
NAME            CREATIONTIME   CSIDRIVERTYPE   CONFIGVERSION   STATE
authorization   65s                                            Succeeded

[ChristianAtDell]

Can you explain this change? Does the authorization proxy server only exist for auth v1?

[atye]

instance.GetName() != string(csmv1.Authorization) checks if the Authorization CSM name is authorization. Assuming the user doesn't modify the default name in the sample, it'll work. If the user changes the CSM name, this check fails and reconciling will have issues.

A better check to determine if a CSM is the Authorization Server is to check the module name for authoriztion-proxy-server, which isAuthorizationProxyServer does.