Skip to content

Remove unsupported config versions for Authorization and Mobility#975

Merged
alexemc merged 16 commits intomainfrom
usr/babija/remove-old-configs
May 7, 2025
Merged

Remove unsupported config versions for Authorization and Mobility#975
alexemc merged 16 commits intomainfrom
usr/babija/remove-old-configs

Conversation

@alexemc
Copy link
Copy Markdown
Contributor

@alexemc alexemc commented May 5, 2025

Description

This PR cleans up unsupported config versions for Authorization and Mobility.

Removed:

  • Auth v1.11.0, v2.0.0-alpha
  • AM v1.1.0, v1.0.3, v1.0.2, v1.0.1, v1.0.0

Remains:

  • Auth v2.2.0, v2.1.0, v2.0.0, v1.14.0, v1.13.0, v1.12.0
  • AM v1.4.0, v1.3.0, v1,2.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Comment on lines +2804 to +2805
oldVersion = "v1.12.0"
newVersion = "v2.0.0"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I predict a coverage drop whenever we drop support for V1 Auth...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when we do, a lot of tests will have to be adjusted or even removed, but so will the code.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 7, 2025

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csm-operator/controllers 90.09% (+0.01%) 👍
github.com/dell/csm-operator/pkg/modules 90.47% (+0.09%) 👍
github.com/dell/csm-operator/pkg/utils 90.30% (+0.20%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csm-operator/controllers/csm_controller.go 90.09% (+0.01%) 686 (+1) 618 (+1) 68 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csm-operator/controllers/csm_controller_test.go
  • github.com/dell/csm-operator/pkg/modules/authorization_test.go
  • github.com/dell/csm-operator/pkg/utils/utils_test.go

@alexemc alexemc merged commit f5b6496 into main May 7, 2025
6 checks passed
@alexemc alexemc deleted the usr/babija/remove-old-configs branch May 7, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants