Skip to content

Remove Cross-Cluster Management From Operator#978

Merged
JacobGros merged 32 commits intomainfrom
pub/remove-cross-cluster-mgmt
May 9, 2025
Merged

Remove Cross-Cluster Management From Operator#978
JacobGros merged 32 commits intomainfrom
pub/remove-cross-cluster-mgmt

Conversation

@JacobGros
Copy link
Copy Markdown
Contributor

@JacobGros JacobGros commented May 7, 2025

Description

This PR does the following:

  • Remove Cross-Cluster Management From Operator, operator will now only be adjusting the cluster its installed on
  • Remove TARGET_CLUSTERS_IDS field, as it will no longer be supported with the latest change
  • Add wrapper to utils.go for yaml.Unmarshal, allowing us to boost UT coverage in utils package
  • Add replication CRD management to replication installs
  • Updates ReadMe for an issue found when e2e testing Auth v2
  • fixes PScale e2e tests

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1749

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran pflex e2e tests, nohup ./run-e2e-test.sh --pflex & results tracked internally
  • Ran pmax e2e tests, nohup ./run-e2e-test.sh --pmax & results tracked internally
  • Ran pscale e2e tests, nohup ./run-e2e-test.sh --pscale & results tracked internally
  • Ran karavi replication tests, results tracked internally

donatwork
donatwork previously approved these changes May 7, 2025
@JacobGros JacobGros requested a review from donatwork May 7, 2025 16:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2025

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csm-operator/controllers 90.39% (+0.31%) 👍
github.com/dell/csm-operator/pkg/modules 90.53% (+0.06%) 👍
github.com/dell/csm-operator/pkg/utils 94.26% (+3.96%) 👍
github.com/dell/csm-operator/tests/e2e/steps 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csm-operator/controllers/csm_controller.go 90.39% (+0.31%) 687 (+1) 621 (+3) 66 (-2) 👍
github.com/dell/csm-operator/pkg/modules/replication.go 87.14% (+0.79%) 241 (+14) 210 (+14) 31 👍
github.com/dell/csm-operator/pkg/utils/status.go 94.15% (-0.06%) 410 (-4) 386 (-4) 24 👎
github.com/dell/csm-operator/pkg/utils/utils.go 95.83% (+6.98%) 552 (-31) 529 (+11) 23 (-42) 👍
github.com/dell/csm-operator/tests/e2e/steps/steps_def.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csm-operator/controllers/csm_controller_test.go
  • github.com/dell/csm-operator/pkg/modules/replication_test.go
  • github.com/dell/csm-operator/pkg/utils/status_test.go
  • github.com/dell/csm-operator/pkg/utils/utils_test.go

@JacobGros JacobGros merged commit 01121d2 into main May 9, 2025
12 checks passed
@JacobGros JacobGros deleted the pub/remove-cross-cluster-mgmt branch May 9, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants