Skip to content

golangci-lint issues resolved#109

Merged
khareRajshree merged 1 commit into
mainfrom
usr/khareRajshree/golint-fix
Jul 25, 2025
Merged

golangci-lint issues resolved#109
khareRajshree merged 1 commit into
mainfrom
usr/khareRajshree/golint-fix

Conversation

@khareRajshree
Copy link
Copy Markdown
Contributor

@khareRajshree khareRajshree commented Jul 25, 2025

Description

This PR included changes for the golangci-lint issues resolved which were failing in the GH actions.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make test
Screenshot 2025-07-25 124629
  • go test -coverprofile=c.out ./...
image

@github-actions
Copy link
Copy Markdown
Contributor

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gobrick/pkg/gobrickutils 100.00% (+100.00%) 🌟
github.com/dell/gobrick/pkg/multipath 98.73% (ø)
github.com/dell/gobrick/pkg/powerpath 91.53% (ø)
github.com/dell/gobrick/pkg/scsi 96.55% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gobrick/pkg/gobrickutils/utils.go 100.00% (+100.00%) 7 (+7) 7 (+7) 0 🌟
github.com/dell/gobrick/pkg/multipath/multipath.go 98.73% (ø) 79 78 1
github.com/dell/gobrick/pkg/powerpath/powerpath.go 91.53% (ø) 59 54 5
github.com/dell/gobrick/pkg/scsi/scsi.go 96.55% (ø) 290 280 10

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/gobrick/pkg/gobrickutils/utils_test.go

@khareRajshree khareRajshree merged commit e4be596 into main Jul 25, 2025
6 checks passed
@khareRajshree khareRajshree deleted the usr/khareRajshree/golint-fix branch July 25, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants