Skip to content

Cleaner unstage devices#128

Merged
kumarkgosa merged 8 commits into
mainfrom
clearnerUnstageDevices
Sep 9, 2025
Merged

Cleaner unstage devices#128
kumarkgosa merged 8 commits into
mainfrom
clearnerUnstageDevices

Conversation

@rajendraindukuri
Copy link
Copy Markdown
Contributor

@rajendraindukuri rajendraindukuri commented Sep 8, 2025

Description

  • Adds a cleaner way to delete multipath devices.
  • This implementation is based on steps as per the RH docs which now makes the cleanup standardised.
  • It takes in a WWN, identify the devices and clean them as per the current status

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/2010

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 9, 2025

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/dell/gobrick 85.55% (+0.30%) 👍
github.com/dell/gobrick/internal/multipath 0.00% (ø)
github.com/dell/gobrick/pkg/multipath 91.30% (-7.43%) 👎
github.com/dell/gobrick/pkg/scsi 96.55% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gobrick/base.go 90.13% (-5.82%) 233 (+85) 210 (+68) 23 (+17) 👎
github.com/dell/gobrick/fc.go 83.65% (-1.36%) 312 (+5) 261 51 (+5) 👎
github.com/dell/gobrick/internal/multipath/interface.go 0.00% (ø) 0 0 0
github.com/dell/gobrick/internal/multipath/multipath_mock.go 0.00% (ø) 0 0 0
github.com/dell/gobrick/pkg/multipath/multipath.go 91.30% (-7.43%) 115 (+36) 105 (+27) 10 (+9) 👎
github.com/dell/gobrick/pkg/scsi/scsi.go 96.55% (ø) 290 280 10

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/gobrick/base_test.go
  • github.com/dell/gobrick/pkg/multipath/multipath_test.go

@rajendraindukuri rajendraindukuri changed the title Clearner unstage devices Cleaner unstage devices Sep 9, 2025
Copy link
Copy Markdown

@Deepak-Ghivari Deepak-Ghivari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumarkgosa kumarkgosa merged commit 8c7470d into main Sep 9, 2025
6 checks passed
@kumarkgosa kumarkgosa deleted the clearnerUnstageDevices branch September 9, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants