Unit test failures fix#57
Merged
Merged
Conversation
francis-nijay
requested review from
alikdell,
atye,
bpjain2004,
coulof,
harishp8889,
hoppea2,
kumarp20,
prablr79,
shaynafinocchiaro,
tdawe and
xuluna
as code owners
donatwork
approved these changes
Sep 18, 2024
Contributor
|
Can see some panic in the log. I believe we should handle it properly. |
Contributor
As per the github action this will run the UT of all packages but make test will only cover 2 packages. |
Contributor
Author
|
Fixing the test failures in other packages is in progress. Will run all tests from github actions preferably |
As there are some methods that are calling the cli with diff diff args so mock should handle it for any args type.
Update mockhelper.go
Contributor
|
Ran UT locally for all packages:
|
donatwork
approved these changes
Sep 19, 2024
Contributor
donatwork
left a comment
donatwork
left a comment
There was a problem hiding this comment.
Good job getting these fixed. Thanks.
suryagupta4
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix unit tests that were failing for some time in fc, iscsi and nvme
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration