Skip to content

Bugfix 1447 clean wwids file#61

Merged
AkshaySainiDell merged 6 commits into
mainfrom
bugfix-1447-clean-wwids-file
Oct 14, 2024
Merged

Bugfix 1447 clean wwids file#61
AkshaySainiDell merged 6 commits into
mainfrom
bugfix-1447-clean-wwids-file

Conversation

@AkshaySainiDell
Copy link
Copy Markdown
Contributor

@AkshaySainiDell AkshaySainiDell commented Oct 10, 2024

Description

Gobrick executes the following set of commands for removing a multipath device:

multipath -f /dev/dm-2
echo 1 > /sys/class/block/sdf/device/delete
multipathd del path /dev/sdf

These commands do not remove entries from the /etc/multipath/wwids file, resulting in stale entries being left behind. The growing count of entries could potentially impact the performance of multipath if the file becomes exceptionally large.

To address this issue, Gobrick should be enhanced to remove a device from the wwids file using below command:

multipath -w mpathX (or WWID)

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1447

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Executed UT
    image
  • Installed the fix with unity driver and validated that the wwids are getting removed from the /etc/multipath/wwids file
    image
    image
    image
  • Installed the fix with powerstore driver and validated that the wwids are getting removed from the /etc/multipath/wwids file
    image
    image

@AkshaySainiDell AkshaySainiDell merged commit 06cfe99 into main Oct 14, 2024
@suryagupta4 suryagupta4 deleted the bugfix-1447-clean-wwids-file branch November 4, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants