Skip to content

Updates Parser as per latest nvme list-subsys output#39

Merged
delldubey merged 1 commit into
mainfrom
update_nvme-list-subsys
Jun 27, 2024
Merged

Updates Parser as per latest nvme list-subsys output#39
delldubey merged 1 commit into
mainfrom
update_nvme-list-subsys

Conversation

@delldubey
Copy link
Copy Markdown
Contributor

Description

  • Updates Parser to reflect latest response for "nvme list-subsys -o json"
  • Updates unit test testdata

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1346

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Cluster Test

shanmydell
shanmydell previously approved these changes Jun 27, 2024
nidtara
nidtara previously approved these changes Jun 27, 2024
Copy link
Copy Markdown

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delldubey delldubey dismissed stale reviews from nidtara and shanmydell via 9da5907 June 27, 2024 12:00
@delldubey delldubey force-pushed the update_nvme-list-subsys branch from bd87480 to 9da5907 Compare June 27, 2024 12:00
@delldubey delldubey requested review from nidtara and shanmydell June 27, 2024 12:01
nidtara
nidtara previously approved these changes Jun 27, 2024
shanmydell
shanmydell previously approved these changes Jun 27, 2024
@delldubey delldubey dismissed stale reviews from shanmydell and nidtara via a635838 June 27, 2024 12:46
@delldubey delldubey force-pushed the update_nvme-list-subsys branch from a635838 to e239354 Compare June 27, 2024 12:49
@delldubey delldubey requested review from nidtara and shanmydell June 27, 2024 12:49
Copy link
Copy Markdown
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delldubey delldubey merged commit 0c79a31 into main Jun 27, 2024
@gallacher gallacher deleted the update_nvme-list-subsys branch June 27, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants